Ensure apache-arrow is external in rollup config (#118)

kylebarron · Apr 18, 2024 · c4ce991 · c4ce991
1 parent c554ef6
commit c4ce991
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## [0.4.2] - 2024-04-18
 
 - Allow `Uint32Array` type in `parseTable`.
+- Ensure `apache-arrow` is marked as an external library in Rollup
 
 ## [0.4.1] - 2024-01-31
 

diff --git a/rollup.config.js b/rollup.config.js
@@ -4,6 +4,7 @@ import dts from "rollup-plugin-dts";
 
 const input = "./src/index.ts";
 const sourcemap = true;
+const external = ["apache-arrow"];
 
 export default [
   {
@@ -14,6 +15,7 @@ export default [
       sourcemap,
     },
     plugins: [typescript()],
+    external,
   },
   {
     input,
@@ -22,6 +24,7 @@ export default [
       format: "es",
     },
     plugins: [dts()],
+    external,
   },
   {
     input,
@@ -31,6 +34,7 @@ export default [
       sourcemap,
     },
     plugins: [typescript()],
+    external,
   },
   {
     input,
@@ -39,7 +43,11 @@ export default [
       format: "umd",
       name: "arrowJsFFI",
       sourcemap,
+      globals: {
+        "apache-arrow": "Arrow",
+      },
     },
     plugins: [typescript(), terser()],
+    external,
   },
 ];