Skip to content

Commit

Permalink
Use node 20 for tests (#329)
Browse files Browse the repository at this point in the history
* Bump to node 20

* remove polyfill
  • Loading branch information
kylebarron authored Sep 18, 2023
1 parent 63f88e7 commit dd0b638
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:

- uses: actions/setup-node@v2
with:
node-version: "18"
node-version: "20"

- name: Build bundle
run: yarn build:test
Expand Down
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,10 @@ By default, `arrow`, `all_compressions`, `reader`, and `writer` features are ena
- `lz4`: Activate LZ4_RAW compression (only applies to the `arrow2` endpoints).
- `debug`: Expose the `setPanicHook` function for better error messages for Rust panics. Additionally compiles CLI debug functions.

## Node <20

On Node versions before 20, you'll have to [polyfill the Web Cryptography API](https://docs.rs/getrandom/latest/getrandom/#nodejs-es-module-support).

## Future work

- [ ] Example of pushdown predicate filtering, to download only chunks that match a specific condition
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"devDependencies": {
"@fastify/static": "^6.10.2",
"@types/node": "^18",
"@types/node": "^20",
"apache-arrow": "^13.0.0",
"arrow-js-ffi": "0.3.0",
"benny": "^3.7.1",
Expand All @@ -21,7 +21,7 @@
"vitest": "^0.34.0"
},
"volta": {
"node": "18.17.0",
"node": "20.7.0",
"yarn": "1.22.19"
}
}
4 changes: 0 additions & 4 deletions tests/js/index.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
import { webcrypto } from "node:crypto";
// @ts-expect-error
globalThis.crypto = webcrypto;

import "./arrow1.test";
import "./arrow1-ffi.test";
import "./arrow2.test";
Expand Down

0 comments on commit dd0b638

Please sign in to comment.