Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ffi code from this crate #342

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Remove ffi code from this crate #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
181 changes: 0 additions & 181 deletions src/arrow1/ffi.rs
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions src/arrow1/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
#[cfg(feature = "reader")]
pub mod reader;

pub mod ffi;

pub mod wasm;

#[cfg(feature = "writer")]
Expand Down
12 changes: 0 additions & 12 deletions src/arrow1/reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
use crate::arrow1::error::Result;
use crate::arrow1::ffi::FFIArrowTable;
use arrow_wasm::arrow1::Table;
use bytes::Bytes;
use parquet::arrow::arrow_reader::ParquetRecordBatchReaderBuilder;
Expand All @@ -22,14 +21,3 @@ pub fn read_parquet(parquet_file: Vec<u8>) -> Result<Table> {

Ok(Table::new(batches))
}

pub fn read_parquet_ffi(parquet_file: Vec<u8>) -> Result<FFIArrowTable> {
// Create Parquet reader
let cursor: Bytes = parquet_file.into();
let builder = ParquetRecordBatchReaderBuilder::try_new(cursor).unwrap();

// Create Arrow reader
let reader = builder.build().unwrap();

FFIArrowTable::try_from_iterator(reader)
}
Loading
Loading