feat: Open id connect resource view #3739
Conversation
KonradPietocha
requested review from
akucharska,
mrCherry97,
dbadura,
chriskari and
OliwiaGowor
as code owners
kyma-bot
added
the
size/M
KonradPietocha
changed the title
| presets: |- | ||
| - name: template | ||
| default: true | ||
| value: | ||
| metadata: | ||
| annotations: | ||
| authentication.gardener.cloud/class: garden |
There was a problem hiding this comment.
I don't think it's necessary
| - source: spec | ||
| name: Specification JSON | ||
| widget: CodeViewer | ||
| language: "'json'" | ||
| - source: metadata | ||
| name: Metadata | ||
| widget: CodeViewer | ||
| language: "'json'" |
There was a problem hiding this comment.
Metadata is in the header, spec is in Panel, it's not so necessary.
| header: | ||
| - source: metadata.name | ||
| name: Name |
There was a problem hiding this comment.
This also could be removed.
| source: spec.clientID | ||
| form: |- | ||
| - path: spec.issuerURL | ||
| visibility: $not((metadata.labels."operator.kyma-project.io/managed-by") = "infrastructure-manager") |
There was a problem hiding this comment.
this couldn't be done as visibility, because the user still can mess up in YAML, this should be done in disableEdit in general section.
| - false | ||
| - path: spec.supportedSigningAlgs | ||
| visibility: $not((metadata.labels."operator.kyma-project.io/managed-by") = "infrastructure-manager") | ||
| overwrite: false |
There was a problem hiding this comment.
What this flag is doing? I don't think it's necessary.
There was a problem hiding this comment.
When visibility is set to false I saw that all fields is somehow overwrite by this and it detects that there are some changes (probably if visibility is false all fields are clearing). This flag prevents this changes but will be not needed if I'll remove visibility and use disableEdit like you suggested.
Description
Changes proposed in this pull request:
Related issue(s)
Closes #3651
Definition of done
backlog#4567