Skip to content

Commit

Permalink
Remove nodejs 14, deprecate nodejs16 (#1690)
Browse files Browse the repository at this point in the history
* remove nodejs 14, deprecate nodejs16

* update docs

* update hydroform
  • Loading branch information
dbadura authored Jun 29, 2023
1 parent 3c54377 commit b818b78
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 11 deletions.
7 changes: 3 additions & 4 deletions cmd/kyma/init/function/function.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const (

var (
deprecatedRuntimes = map[string]struct{}{
"nodejs14": {},
"nodejs16": {},
}
)

Expand Down Expand Up @@ -55,9 +55,8 @@ Use the flags to specify the initial configuration for your Function or to choos
cmd.Flags().StringVarP(
&o.Runtime, "runtime", "r", defaultRuntime,
`Flag used to define the environment for running your Function. Use one of these options:
- nodejs14 (deprecated)
- nodejs16
- nodejs18
- nodejs16 (deprecated)
- nodejs18
- python39`,
)
cmd.Flags().StringVar(&o.SchemaVersion, "schema-version", string(workspace.SchemaVersionDefault), `Version of the config API.`)
Expand Down
1 change: 0 additions & 1 deletion cmd/kyma/run/function/function.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ func (c *command) workspaceConfig(path string) (workspace.Cfg, error) {
}

supportedRuntimes := map[string]struct{}{
"nodejs14": {},
"nodejs16": {},
"nodejs18": {},
"python39": {},
Expand Down
5 changes: 2 additions & 3 deletions docs/gen-docs/kyma_init_function.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,8 @@ kyma init function [flags]
--reference string Commit hash or branch name (default "main")
--repository-name string The name of the Git repository to be created
-r, --runtime string Flag used to define the environment for running your Function. Use one of these options:
- nodejs14 (deprecated)
- nodejs16
- nodejs18
- nodejs16 (deprecated)
- nodejs18
- python39 (default "nodejs18")
--runtime-image-override string Set custom runtime image base.
--schema-version string Version of the config API. (default "v0")
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ require (
github.com/go-logr/zapr v1.2.3
github.com/imdario/mergo v0.3.15
github.com/kyma-incubator/reconciler v0.0.0-20230622145557-b23e244ca299
github.com/kyma-project/hydroform/function v0.0.0-20230607080739-8cda607c4599
github.com/kyma-project/hydroform/function v0.0.0-20230628151226-25b31247e585
github.com/kyma-project/hydroform/provision v0.0.0-20230418133637-1ea26b368bb6
github.com/kyma-project/lifecycle-manager v0.0.0-20230515084114-0cd8e8e80748
github.com/mandelsoft/vfs v0.0.0-20220805210647-bf14a11bfe31
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -1175,8 +1175,8 @@ github.com/kylelemons/godebug v1.1.0 h1:RPNrshWIDI6G2gRW9EHilWtl7Z6Sb1BR0xunSBf0
github.com/kylelemons/godebug v1.1.0/go.mod h1:9/0rRGxNHcop5bhtWyNeEfOS8JIWk580+fNqagV/RAw=
github.com/kyma-incubator/reconciler v0.0.0-20230622145557-b23e244ca299 h1:NZCUfCutAxLWzfwPO+tRbJFoMmfXP+/IVS4LkqW8OU4=
github.com/kyma-incubator/reconciler v0.0.0-20230622145557-b23e244ca299/go.mod h1:VIwWjDGxzzMYyoBhXTHZsoDV/cA1MpQhKHtNOwA2ymc=
github.com/kyma-project/hydroform/function v0.0.0-20230607080739-8cda607c4599 h1:Td//yZwb1Ns64N5H59g9/2o/UtphRcsxPJmWET/mXS8=
github.com/kyma-project/hydroform/function v0.0.0-20230607080739-8cda607c4599/go.mod h1:aNqrx5xoV2sOw5FZFShUzFLpc5VJku9YhokKC3PyQro=
github.com/kyma-project/hydroform/function v0.0.0-20230628151226-25b31247e585 h1:+fs52VM2jVQuVHWpcSVGfD9RXyao3izEm5Z+HYlJ5lk=
github.com/kyma-project/hydroform/function v0.0.0-20230628151226-25b31247e585/go.mod h1:aNqrx5xoV2sOw5FZFShUzFLpc5VJku9YhokKC3PyQro=
github.com/kyma-project/hydroform/provision v0.0.0-20230418133637-1ea26b368bb6 h1:k8TsRKhbYr+uQ1Glpbwii9kBqMPSFEZdMSov9KJjgiA=
github.com/kyma-project/hydroform/provision v0.0.0-20230418133637-1ea26b368bb6/go.mod h1:eXIZaENQU/Y4sq20z3AgiFg6hSZUP4DmQ2JTMtFt+A8=
github.com/kyma-project/istio/operator v0.0.0-20221129102055-d37c5c8e6add h1:ohTtnIlNXSQPHB/nMZvBXs+uBnTqQ6HRSgAvptyWzlc=
Expand Down

0 comments on commit b818b78

Please sign in to comment.