Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move v3 to main #2101

Merged
merged 52 commits into from
May 21, 2024
Merged

chore: Move v3 to main #2101

merged 52 commits into from
May 21, 2024

Conversation

pPrecel
Copy link
Contributor

@pPrecel pPrecel commented May 21, 2024

Description

Changes proposed in this pull request:

  • erase the main branch
  • move the v3 branch to main

pPrecel and others added 30 commits May 21, 2024 09:02
* init go project structure

* go mod tidy
* import image command

* reviewv1

* comment portforward package

---------

Co-authored-by: Andrzej Pankowski <[email protected]>
* configtest

* gomod

* removecomment

* add_test_cases
* add first test

* finish image tests

* improve Connection mock

* apply review suggestions
* add hana provision

* fix help
* Implement better error handling

* test

* Simplify struct name

* make test a bit mor readable

* fix formatting issues

* info

* remove pleonasm
* Add reference-instance command

* add logic

* extract

* apply requested changes

---------

Co-authored-by: Andrzej Pankowski <[email protected]>
@kyma-bot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 21, 2024
@pPrecel pPrecel marked this pull request as ready for review May 21, 2024 07:49
@pPrecel pPrecel requested review from a team as code owners May 21, 2024 07:49
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2024
@pPrecel pPrecel added area/cli Related to all activities around CLI kind/chore Categorizes issue or PR as related to a chore. labels May 21, 2024
@pPrecel pPrecel changed the title Move v3 to main chore: Move v3 to main May 21, 2024
@halamix2
Copy link
Member

/hold
We want to merge this PR manually, without Tide

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@pPrecel pPrecel merged commit bc37e26 into kyma-project:main May 21, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to all activities around CLI cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants