feat: Add dry-run flag to prevent pushing module template to registry #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
|
|
kyma-bot
added
size/XS
KacperMalachowski
changed the title
kyma-bot
removed
the
do-not-merge/work-in-progress
|
@nesmabadr could you revert kyma-project/template-operator#226? It breaks the tests and we still use kyma cli on the submission pipeline. CC: @kyma-project/otters |
|
The content of the default directory is now in https://github.com/kyma-project/template-operator/tree/main/config/overlays/deployment . |
kyma-bot
added
size/S
|
FIxing the e2e tests (at least at level of my knowledge for cli) without breaking it require code breaking change of: https://github.com/kyma-project/cli/blob/release-2.20/pkg/module/kubebuilder/project.go#L21 I really doubt if we can safely fix it for now in code, I can change it in the way it will use older version of template operator module. Question if it's fine for @kyma-project/otters ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In neighbors team, we need to validate only the possibility to push module template to registry.
It's required to write correct check for submission pipeline. See: https://github.tools.sap/kyma/test-infra/issues/469
Changes proposed in this pull request:
dry-runflag tokyma alpha create moduleto preventing push of module templateRelated issue(s)
See: https://github.tools.sap/kyma/test-infra/issues/469