Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add check for label before creating a new comment #2295

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

medmes
Copy link
Member

@medmes medmes commented Mar 6, 2025

Description
This PR is for purpose to reduce the comments on each update on the existing PR.

Changes proposed in this pull request:

  • Add Check if 'manifests-diff' Label Exists step.
  • Add Check if 'pipeline-changed' Label Exists
  • Verify labels conditions before posting a comment.

Related issue(s)
#2269

@medmes medmes requested a review from a team as a code owner March 6, 2025 08:17
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 6, 2025
@medmes medmes linked an issue Mar 6, 2025 that may be closed by this pull request
1 task
@medmes medmes changed the title Add check for label before creating a new comment feat: Add check for label before creating a new comment Mar 6, 2025
@medmes
Copy link
Member Author

medmes commented Mar 6, 2025

The failing test is due to flaky test(related to running unit tests ) , we are waiting for bumping the go version to v1.24.
In order to resolve the issue, we need to ensure GOSUMDB is set to sum.golang.org or unset it to use the default.

I created a separate ticket: #2296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Check Pipeline Changes and Check Manifest Changes workflows less spammy
2 participants