feat: Add disableTransactions option to Migrator #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
igalklebanov
added
enhancement
|
Open in Stackblitz • kysely_koa_example commit: |
igalklebanov
force-pushed
the
iss/352-migrations-no-tx
branch
from
f77ee45 to
6e63119
Compare
igalklebanov
reviewed
Feb 1, 2025
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
disableTransactionsoption to the Migrator.This flag controls whether the migrator will run a migration in a transaction or not, for dialects that support a transactional DDL.
When true, migrations will not be run in a transaction, even if the dialect supports transactions in their DDL.
When false, migrations will be run in a transaction if that is supported by the dialect.
Testing
test/node.CREATE INDEX CONCURRENTLYon a big table. This succeeded whendisableTransactionswas true, and failed (as expected) whendisableTransactionswas false.Closes #352