Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1444 Removed spell check from Kyverno Architecture image #1447

Merged
merged 3 commits into from
Dec 18, 2024
Merged

#1444 Removed spell check from Kyverno Architecture image #1447

merged 3 commits into from
Dec 18, 2024

Conversation

cerebro1
Copy link
Contributor

Related issue

#1444 : #1444

Proposed Changes

Removed the spell check underline from the text in the Kyverno Architecture image

Checklist

  • I have read the contributing guidelines.
  • I have inspected the website preview for accuracy.
  • I have signed off my issue.

Here is image showing changes on my local.
line_removed_first_issue

@welcome Welcome
Copy link

welcome bot commented Dec 17, 2024

Thanks for opening your first Pull Request here! Please check out our Contributing guidelines and confirm that you Signed off.

realshuting
realshuting approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@realshuting realshuting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@realshuting
Copy link
Member

Thansk @cerebro1 for the fix, can you sign off your commit https://github.com/kyverno/website/pull/1447/checks?check_run_id=34518987705?

cerebro1 and others added 2 commits December 17, 2024 14:21
@cerebro1
Removed spell check from Kyverno Architecture image
b5b1527 
Signed-off-by: Sonali Srivastava <[email protected]>
@dependabot @cerebro1
chore(deps): bump golang.org/x/crypto from 0.17.0 to 0.31.0 in /render (
2501664 
kyverno#1445)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.17.0 to 0.31.0.
- [Commits](golang/crypto@v0.17.0...v0.31.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Sonali Srivastava <[email protected]>
@cerebro1
Copy link
Contributor Author

@realshuting Done. Will be careful to add sign-off commit message in the future.

@cerebro1 cerebro1 requested a review from realshuting December 17, 2024 09:59
@cerebro1
Copy link
Contributor Author

Hi @realshuting
Just curious to know who usually approves the workflow. The workflow requires approval from a maintainer for execution even though the PR has been approved by you.

@cerebro1
Copy link
Contributor Author

There is a check showing as failed but this is not related to my changes. Attaching a screenshot for reference.
failed-error

@JimBugwadia JimBugwadia merged commit b1601ab into kyverno:main Dec 18, 2024
5 of 6 checks passed
@welcome Welcome
Copy link

welcome bot commented Dec 18, 2024

Congratulations! 🎉

Great job merging your first Pull Request here! How awesome! If you are new to this project, feel free to join our Slack community.

200w

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimBugwadia JimBugwadia JimBugwadia approved these changes

@realshuting realshuting Awaiting requested review from realshuting

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cerebro1 @realshuting @JimBugwadia