Perfomance fix (#30)

* fix unneeded cast

* added 413 for content over 200kb and 411 if POST without length information

* new restriction: maximum 1000 tx ids for search

* limit light and full search to 10

* unneeded cast operator

* limit TXs to 50

endpoints/get_transactions.py

@@ -5,7 +5,7 @@
 
 from fastapi import Path, HTTPException, Query
 from pydantic import BaseModel, parse_obj_as
-from sqlalchemy import Integer, cast
+from sqlalchemy import Integer
 from sqlalchemy.future import select
 
 from dbsession import async_session
@@ -111,7 +111,7 @@ async def get_transaction(transactionId: str = Path(regex="[a-f0-9]{64}"),
                 tx_inputs = await s.execute(select(TransactionInput, TransactionOutput)
                                             .outerjoin(TransactionOutput,
                                                        (TransactionOutput.transaction_id == TransactionInput.previous_outpoint_hash) &
-                                                       (TransactionOutput.index == cast(TransactionInput.previous_outpoint_index, Integer)))
+                                                       (TransactionOutput.index == TransactionInput.previous_outpoint_index))
                                             .filter(TransactionInput.transaction_id == transactionId))
 
                 tx_inputs = tx_inputs.all()
@@ -170,6 +170,12 @@ async def search_for_transactions(txSearch: TxSearch,
     """
     Get block information for a given block id
     """
+    if len(txSearch.transactionIds) > 1000:
+        raise HTTPException(422, "Too many transaction ids")
+
+    if resolve_previous_outpoints in ["light", "full"] and len(txSearch.transactionIds) > 50:
+        raise HTTPException(422, "Temporary issue: Transaction ids count is limited to 50 for light and full searches.")
+
     fields = fields.split(",") if fields else []
 
     async with async_session() as s:
@@ -186,7 +192,7 @@ async def search_for_transactions(txSearch: TxSearch,
                 tx_inputs = await s.execute(select(TransactionInput, TransactionOutput)
                                             .outerjoin(TransactionOutput,
                                                        (TransactionOutput.transaction_id == TransactionInput.previous_outpoint_hash) &
-                                                       (TransactionOutput.index == cast(TransactionInput.previous_outpoint_index, Integer)))
+                                                       (TransactionOutput.index == TransactionInput.previous_outpoint_index))
                                             .filter(TransactionInput.transaction_id.in_(txSearch.transactionIds)))
 
             # without joining previous_tx_outputs

helper/LimitUploadSize.py

@@ -0,0 +1,20 @@
+from starlette import status
+from starlette.middleware.base import BaseHTTPMiddleware, RequestResponseEndpoint
+from starlette.requests import Request
+from starlette.responses import Response
+
+# from https://github.com/tiangolo/fastapi/issues/362
+
+class LimitUploadSize(BaseHTTPMiddleware):
+    def __init__(self, app, max_upload_size: int) -> None:
+        super().__init__(app)
+        self.max_upload_size = max_upload_size
+
+    async def dispatch(self, request: Request, call_next: RequestResponseEndpoint) -> Response:
+        if request.method == 'POST':
+            if 'content-length' not in request.headers:
+                return Response(status_code=status.HTTP_411_LENGTH_REQUIRED)
+            content_length = int(request.headers['content-length'])
+            if content_length > self.max_upload_size:
+                return Response(status_code=status.HTTP_413_REQUEST_ENTITY_TOO_LARGE)
+        return await call_next(request)

server.py

@@ -11,6 +11,7 @@
 from starlette.requests import Request
 from starlette.responses import JSONResponse
 
+from helper.LimitUploadSize import LimitUploadSize
 from kaspad.KaspadMultiClient import KaspadMultiClient
 
 fastapi.logger.logger.setLevel(logging.WARNING)
@@ -28,6 +29,7 @@
 )
 
 app.add_middleware(GZipMiddleware, minimum_size=500)
+app.add_middleware(LimitUploadSize, max_upload_size=200_000)  # ~1MB
 
 origins = ["*"]