Skip to content

Commit

Permalink
Remove JavaScript unit tests, they are not used
Browse files Browse the repository at this point in the history
  • Loading branch information
Luthaf committed May 6, 2024
1 parent 1a5df27 commit 715afc6
Show file tree
Hide file tree
Showing 11 changed files with 4 additions and 756 deletions.
16 changes: 3 additions & 13 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,9 @@ on:
# Check all PR

jobs:
# Javascript tests and linting
# Javascript linting
npm-test:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: ['18.x', '20.x', '21.x']
steps:
- uses: actions/checkout@v3
# we need the full history to be able to get the chemiscope version with
Expand All @@ -20,22 +17,15 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
node-version: '21.x'
cache: 'npm'

- name: configure access to git repositories in package-lock.json
run: git config --global url."https://github.com/".insteadOf ssh://[email protected]

- name: install npm dependencies
run: npm ci

- run: npm run build

- run: sudo apt-get install xvfb

# use xvfb to run the tests with a pseudo-display attached
# so that the browsers started by karma think there is a screen
- run: xvfb-run --auto-servernum npm test
- run: npm test

# Python unit tests
python-test:
Expand Down
92 changes: 0 additions & 92 deletions karma.conf.ts

This file was deleted.

12 changes: 0 additions & 12 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 1 addition & 15 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@
"url": "git+https://github.com/lab-cosmo/chemiscope.git"
},
"scripts": {
"test": "npm run test:karma && npm run test:lint",
"test:karma": "karma start",
"test:lint": "eslint src && prettier --check src",
"test": "eslint src && prettier --check src",
"build": "rimraf dist && webpack --mode production --config webpack.config.ts && npm run merge-dts",
"build:nbextension": "webpack --mode production --config python/webpack.config.nbextension.ts",
"build:labextension": "npm run build && jupyter labextension build .",
Expand All @@ -45,11 +43,8 @@
"@jupyter-widgets/base": "^2 || ^3 || ^4 || ^5 || ^6",
"@jupyterlab/builder": "^4",
"@popperjs/core": "^2.11.2",
"@types/chai": "^4",
"@types/jquery": "^3.5",
"@types/karma": "^6",
"@types/markdown-it": "^14",
"@types/mocha": "^10",
"@types/node": "^20",
"@types/pako": "^2",
"@types/plotly.js": "^2.12",
Expand All @@ -61,7 +56,6 @@
"bootstrap": "^5",
"bubleify": "^2.0.0",
"buffer": "^6",
"chai": "^4",
"construct-style-sheets-polyfill": "^3.1.0",
"color-parse": "^1",
"css-loader": "^7",
Expand All @@ -71,17 +65,9 @@
"eslint-plugin-prettier": "^5",
"ify-loader": "^1.1",
"jquery": "^3.6",
"karma": "^6.3.16",
"karma-chrome-launcher": "^3.1",
"karma-detect-browsers": "^2.3",
"karma-firefox-launcher": "^2.1",
"karma-mocha": "^2.0",
"karma-safari-applescript-launcher": "^0.1",
"karma-webpack": "https://github.com/ryanclark/karma-webpack/archive/ef7edb6b6756fb563871eaff88ca876892694896.tar.gz",
"less": "^4.1",
"less-loader": "^12",
"markdown-it": "^14",
"mocha": "^10",
"node-loader": "^2",
"pako": "^2",
"plausible-tracker": "^0.3.8",
Expand Down
123 changes: 0 additions & 123 deletions tests/indexer.test.ts

This file was deleted.

Loading

0 comments on commit 715afc6

Please sign in to comment.