Added cylinder shape type #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vertices are accumulated and added at once rather than one shape at a time
|
Wanted to make a path integral visualization and got a bit dragged away. Overall these are just a few improvements to the shapes functionality:
|
Luthaf
reviewed
Dec 11, 2023
|
OK all done. @Luthaf - since Rose has things to take care of these days, if you're happy I'd merge and move on. |
rosecers
reviewed
Dec 11, 2023
Co-authored-by: Rose K. Cersonsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple, self-contained PR to include a cylinder shape - started off to switch to cylinder when headLength was zero, but it seems cleaner to have a separate object even if it was a bit more coding.