Ryan submission screen frontend #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
he-is-james
reviewed
Jul 25, 2023
Comment on lines
+24
to
+26
| // app.use(express.json()); | ||
| // app.use(express.json({ limit: '50mb' })); | ||
| // app.use(express.urlencoded({ limit: '50mb', extended: true })); |
he-is-james
reviewed
Jul 25, 2023
Comment on lines
+27
to
+28
| app.use(bodyParser.json({limit: '50mb'})); | ||
| app.use(bodyParser.urlencoded({limit: '50mb', extended: true})); |
There was a problem hiding this comment.
tried to upload a video and it said that the payload was too large, unsure if this needs to be increased
he-is-james
requested changes
Jul 25, 2023
There was a problem hiding this comment.
The feature looks amazing, great job with the video and audio player as well as the attention to detail with the design.
Currently there are two issues I'm having:
- It is really slow to upload. I tested with a video and then it got rejected. The size limit might need to be increased
- I tested with two photos and it worked but there was an error
[TypeError: undefined is not an object (evaluating 'files[carouselIdx].type')]despite it successfully uploading. Maybe a loading animation is needed for people to wait because nothing happened in the meantime
he-is-james
reviewed
Jul 25, 2023
| @@ -172,10 +215,46 @@ function SubmissionScreen() { | |||
| }; | |||
|
|
|||
| const submit = async () => { | |||
There was a problem hiding this comment.
there might need to be an additional check here to prevent null values?
he-is-james
reviewed
Jul 25, 2023
Comment on lines
+281
to
+282
| name: 'Ryan', | ||
| email: '[email protected]', |
There was a problem hiding this comment.
when you integrate it with accounts, remember to use redux to get the user id and then call api route for get name and email (you can create a new route which would be pretty simple or let me know and I can do it for you)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of frontend changes, looks like how it does in the demo day presentation. I still need to work on popups, integrating user ID (the name, socials, etc. are all hard coded right now), and cleaning up the code. Besides that, everything else is done unless designers have any last minute requests.