Skip to content

Commit

Permalink
fix: change extended-image-info version to 24.12.0 (#2811)
Browse files Browse the repository at this point in the history 
Updates version references from 24.09.1 to 24.12.0 for extended image information features

This PR updates version references for extended image information features (namespace, base_image_name, tags, version) from 24.09.1 to 24.12.0 across GraphQL schema and React components. This change ensures proper version compatibility checks and deprecation notices.

**Checklist:**

- [ ] Minimum required manager version: 24.12.0
- [ ] Minimum requirements to check:
  - Verify extended image information features work correctly with manager version 24.12.0
  - Confirm deprecation notices display properly for the `name` field
  - Validate version compatibility checks in backend client

The changes affect:
- GraphQL schema deprecation notices and version tags
- React component queries and version checks
- Backend client version compatibility detection
  • Loading branch information
@agatha197
agatha197 committed Nov 5, 2024
1 parent 088c949 commit 53a8fe2
Show file tree
Hide file tree
Showing 6 changed files with 32 additions and 32 deletions.
22 changes: 11 additions & 11 deletions react/data/schema.graphql
View file
Original file line number Diff line number Diff line change
Expand Up @@ -320,23 +320,23 @@ type ImageNode implements Node {

"""Added in 24.03.4. The undecoded id value stored in DB."""
row_id: UUID
name: String @deprecated(reason: "Deprecated since 24.09.1. use `namespace` instead")
name: String @deprecated(reason: "Deprecated since 24.12.0. use `namespace` instead")

"""Added in 24.09.1."""
"""Added in 24.12.0."""
namespace: String

"""Added in 24.09.1."""
"""Added in 24.12.0."""
base_image_name: String

"""Added in 24.03.10."""
project: String
humanized_name: String
tag: String

"""Added in 24.09.1."""
"""Added in 24.12.0."""
tags: [KVPair]

"""Added in 24.09.1."""
"""Added in 24.12.0."""
version: String
registry: String
architecture: String
Expand Down Expand Up @@ -411,7 +411,7 @@ type DomainNode implements Node {
scaling_groups(filter: String, order: String, offset: Int, before: String, after: String, first: Int, last: Int): ScalinGroupConnection
}

"""Added in 24.09.1."""
"""Added in 24.12.0."""
scalar Bytes

"""Added in 24.12.0."""
Expand Down Expand Up @@ -757,23 +757,23 @@ type Group {

type Image {
id: UUID
name: String @deprecated(reason: "Deprecated since 24.09.1. use `namespace` instead")
name: String @deprecated(reason: "Deprecated since 24.12.0. use `namespace` instead")

"""Added in 24.09.1."""
"""Added in 24.12.0."""
namespace: String

"""Added in 24.09.1."""
"""Added in 24.12.0."""
base_image_name: String

"""Added in 24.03.10."""
project: String
humanized_name: String
tag: String

"""Added in 24.09.1."""
"""Added in 24.12.0."""
tags: [KVPair]

"""Added in 24.09.1."""
"""Added in 24.12.0."""
version: String
registry: String
architecture: String
Expand Down
2 changes: 1 addition & 1 deletion react/src/components/AliasedImageDoubleTags.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const AliasedImageDoubleTags: React.FC<AliasedImageDoubleTagsProps> = ({
key
value
}
tags @since(version: "24.09.1") {
tags @since(version: "24.12.0") {
key
value
}
Expand Down
14 changes: 7 additions & 7 deletions react/src/components/CustomizedImageList.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ const CustomizedImageList: React.FC<PropsWithChildren> = ({ children }) => {
query CustomizedImageListQuery {
customized_images {
id
name @deprecatedSince(version: "24.09.1")
name @deprecatedSince(version: "24.12.0")
humanized_name
tag
registry
Expand All @@ -88,13 +88,13 @@ const CustomizedImageList: React.FC<PropsWithChildren> = ({ children }) => {
value
}
supported_accelerators
namespace @since(version: "24.09.1")
base_image_name @since(version: "24.09.1")
tags @since(version: "24.09.1") {
namespace @since(version: "24.12.0")
base_image_name @since(version: "24.12.0")
tags @since(version: "24.12.0") {
key
value
}
version @since(version: "24.09.1")
version @since(version: "24.12.0")
...AliasedImageDoubleTagsFragment
}
}
Expand Down Expand Up @@ -136,7 +136,7 @@ const CustomizedImageList: React.FC<PropsWithChildren> = ({ children }) => {
namespace: supportExtendedImageInfo ? image?.namespace : image?.name,
fullName: getImageFullName(image) || '',
digest: image?.digest || '',
// ------------ need only before 24.09.1 ------------
// ------------ need only before 24.12.0 ------------
lang: image?.name ? getLang(image.name) : '',
baseversion: getBaseVersion(getImageFullName(image) || ''),
baseimage:
Expand All @@ -152,7 +152,7 @@ const CustomizedImageList: React.FC<PropsWithChildren> = ({ children }) => {
? image.tag.indexOf('customized') !== -1
: false,
// -------------------------------------------------
// ------------ need only after 24.09.1 ------------
// ------------ need only after 24.12.0 ------------
baseImageName: supportExtendedImageInfo ? image?.base_image_name : '',
tags: supportExtendedImageInfo ? image?.tags : [],
version: supportExtendedImageInfo ? image?.version : '',
Expand Down
10 changes: 5 additions & 5 deletions react/src/components/ImageEnvironmentSelectFormItems.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ const ImageEnvironmentSelectFormItems: React.FC<
query ImageEnvironmentSelectFormItemsQuery($installed: Boolean) {
images(is_installed: $installed) {
id
name @deprecatedSince(version: "24.09.1")
name @deprecatedSince(version: "24.12.0")
humanized_name
tag
registry
Expand All @@ -128,13 +128,13 @@ const ImageEnvironmentSelectFormItems: React.FC<
key
value
}
namespace @since(version: "24.09.1")
base_image_name @since(version: "24.09.1")
tags @since(version: "24.09.1") {
namespace @since(version: "24.12.0")
base_image_name @since(version: "24.12.0")
tags @since(version: "24.12.0") {
key
value
}
version @since(version: "24.09.1")
version @since(version: "24.12.0")
}
}
`,
Expand Down
14 changes: 7 additions & 7 deletions react/src/components/ImageList.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const ImageList: React.FC<{ style?: React.CSSProperties }> = ({ style }) => {
query ImageListQuery {
images {
id
name @deprecatedSince(version: "24.09.1")
name @deprecatedSince(version: "24.12.0")
tag
registry
architecture
Expand All @@ -90,13 +90,13 @@ const ImageList: React.FC<{ style?: React.CSSProperties }> = ({ style }) => {
min
max
}
namespace @since(version: "24.09.1")
base_image_name @since(version: "24.09.1")
tags @since(version: "24.09.1") {
namespace @since(version: "24.12.0")
base_image_name @since(version: "24.12.0")
tags @since(version: "24.12.0") {
key
value
}
version @since(version: "24.09.1")
version @since(version: "24.12.0")
}
}
`,
Expand Down Expand Up @@ -429,7 +429,7 @@ const ImageList: React.FC<{ style?: React.CSSProperties }> = ({ style }) => {
namespace: supportExtendedImageInfo ? image?.namespace : image?.name,
fullName: getImageFullName(image) || '',
digest: image?.digest || '',
// ------------ need only before 24.09.1 ------------
// ------------ need only before 24.12.0 ------------
lang: image?.name ? getLang(image.name) : '',
baseversion: getBaseVersion(getImageFullName(image) || ''),
baseimage:
Expand All @@ -445,7 +445,7 @@ const ImageList: React.FC<{ style?: React.CSSProperties }> = ({ style }) => {
? image.tag.indexOf('customized') !== -1
: false,
// -------------------------------------------------
// ------------ need only after 24.09.1 ------------
// ------------ need only after 24.12.0 ------------
baseImageName: supportExtendedImageInfo ? image?.base_image_name : '',
tags: supportExtendedImageInfo ? image?.tags : [],
version: supportExtendedImageInfo ? image?.version : '',
Expand Down
2 changes: 1 addition & 1 deletion src/lib/backend.ai-client-esm.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,7 @@ class Client {
this._features['extend-login-session'] = true;
this._features['session-node'] = true;
}
if (this.isManagerVersionCompatibleWith('24.09.1')) {
if (this.isManagerVersionCompatibleWith('24.12.0')) {
this._features['extended-image-info'] = true;
}
}
Expand Down

0 comments on commit 53a8fe2

Please sign in to comment.