Skip to content

Commit

Permalink
fix: missed i18n (#2827)
Browse files Browse the repository at this point in the history
Internationalize notification edit button text in session launcher

Changes the hardcoded Korean text "수정" to use the internationalized string key `t('button.Edit')` for the edit button text in session notifications.

**Checklist:**

- [ ] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
  • Loading branch information
agatha197 committed Nov 7, 2024
1 parent e08144c commit 6002459
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion react/src/pages/SessionLauncherPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@ const SessionLauncherPage = () => {
upsertNotification({
key: 'session-launcher:' + sessionName,
to: backupTo,
toText: '수정',
toText: t('button.Edit'),
});
// this.metadata_updating = false;
// console.log(err);
Expand Down

0 comments on commit 6002459

Please sign in to comment.