-
Notifications
You must be signed in to change notification settings - Fork 73
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: disable edit button based on endpoint status (#2695)
### TL;DR An update that prevents modifications to an endpoint in `destroyed` and `destroying` state. ### What changed? - Updated status checks to include both 'destroying' and 'destroyed' states - Disabled certain buttons and actions when an endpoint is in 'destroying' or 'destroyed' state [Additionally] - Changed "LLM Playground" tooltip to "LLM Chat Test" in EndpointDetailPage ### How to test? 1. Navigate to the Endpoint List and Detail pages 2. Verify that buttons are properly disabled for endpoints in 'destroying' or 'destroyed' states 3. Check that the tooltip for the LLM chat test button now reads "LLM Chat Test" 4. Attempt to perform actions on endpoints in various states to ensure correct behavior ### Why make this change? This change improves the user experience by: 1. Providing more accurate UI feedback for endpoint statuses 2. Preventing actions on endpoints that are no longer active 3. Ensuring consistency in how endpoint statuses are handled across the application 4. Clarifying the purpose of the LLM chat test button with an updated tooltip --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
- Loading branch information
1 parent
7fe5730
commit 612b54c
Showing
2 changed files
with
35 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters