fix: Unable to revoke shared folder permission and refactor the modify permissions modal. #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:fix
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
This was referenced Aug 19, 2024
yomybaby
force-pushed
the
bugfix/revoke-shared-folder-permission-does-not-work
branch
from
38435c3
to
01d329e
Compare
yomybaby
requested changes
Aug 20, 2024
agatha197
changed the base branch from
fix/share-button-disapear
to
graphite-base/2644
agatha197
force-pushed
the
graphite-base/2644
branch
from
6a5ac11
to
2f0ebc8
Compare
agatha197
force-pushed
the
bugfix/revoke-shared-folder-permission-does-not-work
branch
from
01d329e
to
23a061c
Compare
agatha197
force-pushed
the
bugfix/revoke-shared-folder-permission-does-not-work
branch
3 times, most recently
from
59d4070
to
d84f743
Compare
agatha197
force-pushed
the
bugfix/revoke-shared-folder-permission-does-not-work
branch
2 times, most recently
from
b6052e3
to
e923a63
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 3.68% (-0.03% 🔻) |
215/5849 |
| 🔴 | Branches | 4.04% (-0.01% 🔻) |
159/3940 |
| 🔴 | Functions | 2.22% (-0.02% 🔻) |
43/1941 |
| 🔴 | Lines | 3.56% (-0.03% 🔻) |
204/5730 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / InviteFolderPermissionSettingModal.tsx |
0% | 0% | 0% | 0% |
Test suite run success
71 tests passing in 7 suites.
Report generated by 🧪jest coverage report action from 7a1f8a2
agatha197
force-pushed
the
bugfix/revoke-shared-folder-permission-does-not-work
branch
from
e923a63
to
3a13f63
Compare
agatha197
force-pushed
the
bugfix/revoke-shared-folder-permission-does-not-work
branch
from
3a13f63
to
4a653b2
Compare
github-actions
bot
added
area:ux
agatha197
force-pushed
the
bugfix/revoke-shared-folder-permission-does-not-work
branch
3 times, most recently
from
7c4b7a7
to
8e79e39
Compare
agatha197
changed the title
agatha197
changed the title
agatha197
force-pushed
the
bugfix/revoke-shared-folder-permission-does-not-work
branch
from
8e79e39
to
cae264b
Compare
gahyuun
approved these changes
Aug 22, 2024
yomybaby
force-pushed
the
bugfix/revoke-shared-folder-permission-does-not-work
branch
from
cae264b
to
6e742c0
Compare
Merge activity
|
…y permissions modal. (#2644) resolves #2545 related PR: lablup/backend.ai#2731, lablup/backend.ai#2740 ### TL;DR Fix a bug that changes the permissions of other people in the shared list. ### What changed? - Updated the translation key for renaming a folder from 'data.folders.RenameAFolder' to 'data.explorer.RenameAFolder'. - Refactored the permission modification logic to improve type safety and readability. - Fixed a syntax error in the "Kick Out" list item by removing an extra quotation mark. ### How to test? 1. check out core branch to lablup/backend.ai#2740, and cherry pick lablup/backend.ai#2731 2. Navigate to the storage list component. 3. Attempt to rename a folder and verify the correct translation is displayed. 4. Modify permissions for shared folders and ensure the changes are applied correctly. 5. Check that the "Kick Out" option in the permission dropdown works as expected. 6. Check the permission select has valid value just after accepting the invitation. ### Why make this change? These changes improve the user experience by ensuring correct translations are used and enhance the reliability of permission management. The refactored code also improves maintainability and reduces potential bugs related to type mismatches. ### Screenshot <img width="542" alt="image" src="https://github.com/user-attachments/assets/17b8cf7e-fc7a-4975-ab9d-baebe479bbd0"> <img width="537" alt="image" src="https://github.com/user-attachments/assets/22e16773-322b-4686-83e3-b284aaf654db"> <img width="543" alt="image" src="https://github.com/user-attachments/assets/4aab0493-c31f-4178-8504-2d0f10293070"> --- **Checklist:** (if applicable) - [x] Mention to the original issue - [ ] Documentation - [x] Minium required manager version: 23.09 - [x] Specific setting for review (eg., KB link, endpoint or how to setup): refer [#2545](#2545) - [x] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
force-pushed
the
bugfix/revoke-shared-folder-permission-does-not-work
branch
from
6e742c0
to
7a1f8a2
Compare
graphite-app
bot
deleted the
bugfix/revoke-shared-folder-permission-does-not-work
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2545
related PR: lablup/backend.ai#2731, lablup/backend.ai#2740
TL;DR
Fix a bug that changes the permissions of other people in the shared list.
What changed?
How to test?
list_shared_vfoldersbackend.ai#2731Why make this change?
These changes improve the user experience by ensuring correct translations are used and enhance the reliability of permission management. The refactored code also improves maintainability and reduces potential bugs related to type mismatches.
Screenshot
Checklist: (if applicable)