style: remove bottom margin of model store error message #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 3.7% | 215/5807 |
| 🔴 | Branches | 4.05% | 159/3926 |
| 🔴 | Functions | 2.24% | 43/1920 |
| 🔴 | Lines | 3.59% | 204/5688 |
Test suite run success
71 tests passing in 7 suites.
Report generated by 🧪jest coverage report action from 67f8d9e
ironAiken2
force-pushed
the
style/remove-bottom-margin-of-model-store-error-msg
branch
from
fd481a0
to
0d4085d
Compare
Merge activity
|
### TL;DR Improved error message display in ModelStoreListPage component. ### What changed? Added a `style` prop to the `Typography.Paragraph` component within the `Alert` message. This sets the `marginBottom` to 0, removing any extra space below the error message. ### How to test? 1. Navigate to the ModelStoreListPage. 2. Trigger an error condition that displays an error message. 3. Verify that the error message is displayed without extra bottom margin. 4. Compare with the previous version to ensure the spacing has been reduced. ### Why make this change? This change improves the visual consistency and compactness of error messages in the ModelStoreListPage. By removing the extra bottom margin, it ensures that error messages are displayed more efficiently, especially in cases where multiple errors might be shown. --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [x] Specific setting for review (eg., KB link, endpoint or how to setup) - [x] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
ironAiken2
force-pushed
the
style/remove-bottom-margin-of-model-store-error-msg
branch
from
0d4085d
to
67f8d9e
Compare
graphite-app
bot
deleted the
style/remove-bottom-margin-of-model-store-error-msg
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Improved error message display in ModelStoreListPage component.
What changed?
Added a
styleprop to theTypography.Paragraphcomponent within theAlertmessage. This sets themarginBottomto 0, removing any extra space below the error message.How to test?
Why make this change?
This change improves the visual consistency and compactness of error messages in the ModelStoreListPage. By removing the extra bottom margin, it ensures that error messages are displayed more efficiently, especially in cases where multiple errors might be shown.
Checklist: (if applicable)