add: convert showing all environment images including uninstalled ones by config #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.47% (-0% 🔻) |
337/6157 |
| 🔴 | Branches | 5.06% (-0% 🔻) |
214/4232 |
| 🔴 | Functions | 3.11% | 63/2023 |
| 🔴 | Lines | 5.37% (-0% 🔻) |
323/6013 |
Test suite run success
90 tests passing in 11 suites.
Report generated by 🧪jest coverage report action from 7b8aaac
yomybaby
requested changes
Sep 9, 2024
| export async function readConfigFileFromPath(page: Page, rawPath) { | ||
| const filePath = path.resolve(__dirname, rawPath); | ||
| const mockData = await fs.readFile(filePath, 'utf-8'); | ||
| await page.route('http://127.0.0.1:9081/config.toml', async (route) => { |
There was a problem hiding this comment.
Please use webuiEndpoint from test-util.ts instead of 127.0.0.1:9081 in this file and login.test.ts.
lizable
force-pushed
the
feature/support-showing-all-environment-images-by-config
branch
from
bfe2eea
to
b0ebc2c
Compare
yomybaby
requested changes
Sep 9, 2024
lizable
force-pushed
the
feature/support-showing-all-environment-images-by-config
branch
3 times, most recently
from
ae95a28
to
4eb23eb
Compare
yomybaby
requested changes
Sep 9, 2024
| import { loginAsAdmin, mockConfigToml, webuiEndpoint } from './test-util'; | ||
| import { test, expect } from '@playwright/test'; | ||
|
|
||
| test.describe('config read and test', () => { |
There was a problem hiding this comment.
Suggested change
| test.describe('config read and test', () => { | |
| test.describe('config.toml', () => { |
Merge activity
|
yomybaby
pushed a commit
that referenced
this pull request
Sep 9, 2024
…s by config (#2697) ### TL;DR Added option to show all environment images, regardless of installation status. ### What changed? - Introduced a new configuration option `showNonInstalledImages` in `config.toml.sample` - Updated `ImageEnvironmentSelectFormItems` component to use the new configuration - Added `showNonInstalledImages` to the `BackendAIConfig` type - Implemented the new configuration in the `BackendAILogin` component
yomybaby
force-pushed
the
feature/support-showing-all-environment-images-by-config
branch
from
8a6bc8e
to
e261a78
Compare
…s by config (#2697) ### TL;DR Added option to show all environment images, regardless of installation status. ### What changed? - Introduced a new configuration option `showNonInstalledImages` in `config.toml.sample` - Updated `ImageEnvironmentSelectFormItems` component to use the new configuration - Added `showNonInstalledImages` to the `BackendAIConfig` type - Implemented the new configuration in the `BackendAILogin` component
yomybaby
force-pushed
the
feature/support-showing-all-environment-images-by-config
branch
from
e261a78
to
7b8aaac
Compare
graphite-app
bot
deleted the
feature/support-showing-all-environment-images-by-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added option to show all environment images, regardless of installation status.
What changed?
showNonInstalledImagesinconfig.toml.sampleImageEnvironmentSelectFormItemscomponent to use the new configurationshowNonInstalledImagesto theBackendAIConfigtypeBackendAILogincomponent