fix: remove duplicated form.getFieldValue in ensureValidAcceleratorType
#2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.47% | 337/6156 |
| 🔴 | Branches | 5.06% | 214/4230 |
| 🔴 | Functions | 3.11% | 63/2023 |
| 🔴 | Lines | 5.37% | 323/6012 |
Test suite run success
90 tests passing in 11 suites.
Report generated by 🧪jest coverage report action from d591ffe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixed form field value retrieval for accelerator type in ResourceAllocationFormItems component.
What changed?
Updated the
ensureValidAcceleratorTypefunction(#2628) to correctly retrieve the accelerator type from the form. The previous implementation was incorrectly nested, potentially leading to undefined values. The new implementation directly accesses the 'resource.acceleratorType' field.How to test?
Please ref to the #2628 's "How to test" section
Why make this change?
This change ensures that the correct accelerator type is always retrieved from the form, preventing potential bugs or unexpected behavior when validating or updating the accelerator type. It improves the reliability of the resource allocation process and enhances the overall user experience when configuring resources.