Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use id as a key of Image #2702

Merged
merged 1 commit into from
Oct 4, 2024
Merged

fix: use id as a key of Image #2702

merged 1 commit into from
Oct 4, 2024

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Sep 11, 2024

TL;DR

Updated image identification and selection logic in ImageEnvironmentSelectFormItems component.
Images can have the same digest, but it's a rare case.

What changed?

  • Added 'id' field to the GraphQL query for images
  • Changed image uniqueness check from 'digest' to 'id'
  • Updated Select.Option key from 'image?.digest' to 'image?.id'
  • Added 'id' property to Image type in ResourceAllocationFormItems test

Copy link

graphite-app bot commented Sep 11, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the size:XS ~10 LoC label Sep 11, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @yomybaby and the rest of your teammates on Graphite Graphite

@yomybaby yomybaby marked this pull request as ready for review September 11, 2024 02:05
Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 5.47% 337/6157
🔴 Branches 5.06% 214/4232
🔴 Functions 3.11% 63/2023
🔴 Lines 5.37% 323/6013

Test suite run success

90 tests passing in 11 suites.

Report generated by 🧪jest coverage report action from 2023cd5

Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby merged commit b1d70fb into main Oct 4, 2024
10 checks passed
@yomybaby yomybaby deleted the fix/use-id-as-image-key branch October 4, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants