test: e2e test for parsing config.toml and modifying #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ironAiken2 and the rest of your teammates on |
ironAiken2
force-pushed
the
feat/e2e-test-for-config
branch
from
e4e7303
to
da6d698
Compare
ironAiken2
changed the title
config.toml and modifying
ironAiken2
changed the title
config.toml and modifying
ironAiken2
force-pushed
the
feat/e2e-test-for-config
branch
from
da6d698
to
6e9d0e1
Compare
ironAiken2
changed the title
ironAiken2
force-pushed
the
feat/e2e-test-for-config
branch
from
6e9d0e1
to
bfb2575
Compare
lizable
requested changes
Sep 19, 2024
There was a problem hiding this comment.
please update package.json file and could we use "https://www.npmjs.com/package/smol-toml" instead of iarna/toml package?
The last update is about 4 years ago, so I think it's better to use the package with active updates.
|
For the toml parser library, I chose the library with the highest weekly downloads because I think it's a library that won't need frequent modifications once the code is established. |
|
Okay, Let's apply this library for now. |
Merge activity
|
### TL;DR Updated e2e tests for config.toml and added TOML parsing functionality. ### What changed? - Removed `config-test.toml` file - Updated `config.test.ts` to include new tests for blocklist and showNonInstalledImages - Modified `test-util.ts` to include a new `modifyConfigToml` function - Added `@iarna/toml` dependency to `package.json` and `pnpm-lock.yaml` The toml parser currently used by webui has a lot of [issues](#2382), so I used a different library, [`@iarna/toml`](https://github.com/iarna/iarna-toml). ### How to test? 1. Run the e2e tests for the config.toml file: - Test the blocklist functionality by checking if specified menu items are hidden and their pages are inaccessible - Test the showNonInstalledImages setting by verifying the visibility of non-installed images 2. Verify that the `modifyConfigToml` function works correctly by running the tests and checking if the config.toml file is modified as expected ### Why make this change? This change improves the e2e testing capabilities for the config.toml file, allowing for more dynamic and comprehensive testing of configuration options. The addition of TOML parsing functionality enables easier manipulation of the config file during tests, providing a more flexible and maintainable testing approach. --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
lizable
force-pushed
the
feat/e2e-test-for-config
branch
from
bfb2575
to
406b5ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Updated e2e tests for config.toml and added TOML parsing functionality.
What changed?
config-test.tomlfileconfig.test.tsto include new tests for blocklist and showNonInstalledImagestest-util.tsto include a newmodifyConfigTomlfunction@iarna/tomldependency topackage.jsonandpnpm-lock.yamlThe toml parser currently used by webui has a lot of issues, so I used a different library,
@iarna/toml.How to test?
Run the e2e tests for the config.toml file:
Verify that the
modifyConfigTomlfunction works correctly by running the tests and checking if the config.toml file is modified as expectedWhy make this change?
This change improves the e2e testing capabilities for the config.toml file, allowing for more dynamic and comprehensive testing of configuration options. The addition of TOML parsing functionality enables easier manipulation of the config file during tests, providing a more flexible and maintainable testing approach.
Checklist: (if applicable)