Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move architecture column in session list to the very end #2735

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Oct 7, 2024

Changes:

This PR reorders the columns in the session list grid. The "Architecture" column has been moved from its previous position to the end of the column list. This change can make it easy to resize the agents column.

Rationale:

The reordering of columns aims to improve the logical flow of information presented to users. By moving the "Architecture" column to the end, it allows for more critical or frequently accessed information to be displayed first, potentially enhancing user experience and efficiency when viewing session details.

Effects:

  • Users will see the "Architecture" information as the rightmost column in the session list grid.
  • The order of information presented in the session list is altered, which may affect how users scan and interpret the data.

How to test:

  1. login with superadmin
  2. make a new session
  3. check architecture column was moved to the very end.

Screenshots:
image.png

Checklist:

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/afteimage.pngr

Copy link

graphite-app bot commented Oct 7, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the size:S 10~30 LoC label Oct 7, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @agatha197 and the rest of your teammates on Graphite Graphite

Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agatha197 agatha197 merged commit 2c1d7ef into main Oct 10, 2024
9 checks passed
@agatha197 agatha197 deleted the feature/move-architecture-to-end branch October 10, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants