Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add session name copy button #2736

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Oct 7, 2024

Changes:

  • Added a new "Copy" button next to the session name in the session list
  • The new button allows users to easily copy the session name to the clipboard
  • Updated CSS to apply the same icon size styling to both rename and copy icons

Rationale:

This change enhances user experience by providing a quick and convenient way to copy session names, which can be useful for referencing or sharing session information.

Effects:

  • Users can now copy session names with a single click, improving efficiency
  • The UI remains consistent with the existing design, maintaining visual harmony

Screenshots:

image.png

image.png

Checklist:

  • Documentation
  • Test case(s) to demonstrate the difference of before/after

Copy link

graphite-app bot commented Oct 7, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @agatha197 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the size:S 10~30 LoC label Oct 7, 2024
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Oct 21, 2024

Merge activity

**Changes:**

- Added a new "Copy" button next to the session name in the session list
- The new button allows users to easily copy the session name to the clipboard
- Updated CSS to apply the same icon size styling to both rename and copy icons

**Rationale:**

This change enhances user experience by providing a quick and convenient way to copy session names, which can be useful for referencing or sharing session information.

**Effects:**

- Users can now copy session names with a single click, improving efficiency
- The UI remains consistent with the existing design, maintaining visual harmony

**Screenshots:**

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/5650c335-6b0b-4695-b1bb-9ea8677812bc.png)

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/53a0d135-b9b5-4106-8cce-b51c38ac4e04.png)

**Checklist:**

- [ ] Documentation
- [ ] Test case(s) to demonstrate the difference of before/after
@agatha197 agatha197 force-pushed the feature/add-session-name-copy-button branch from 64ed180 to 9ea769d Compare October 21, 2024 07:38
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graphite-app graphite-app bot merged commit 9ea769d into main Oct 21, 2024
6 checks passed
@graphite-app graphite-app bot deleted the feature/add-session-name-copy-button branch October 21, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants