-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add session name copy button #2736
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on Graphite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge activity
|
**Changes:** - Added a new "Copy" button next to the session name in the session list - The new button allows users to easily copy the session name to the clipboard - Updated CSS to apply the same icon size styling to both rename and copy icons **Rationale:** This change enhances user experience by providing a quick and convenient way to copy session names, which can be useful for referencing or sharing session information. **Effects:** - Users can now copy session names with a single click, improving efficiency - The UI remains consistent with the existing design, maintaining visual harmony **Screenshots:** ![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/5650c335-6b0b-4695-b1bb-9ea8677812bc.png) ![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/53a0d135-b9b5-4106-8cce-b51c38ac4e04.png) **Checklist:** - [ ] Documentation - [ ] Test case(s) to demonstrate the difference of before/after
64ed180
to
9ea769d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes:
Rationale:
This change enhances user experience by providing a quick and convenient way to copy session names, which can be useful for referencing or sharing session information.
Effects:
Screenshots:
Checklist: