Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add a space between Environments and Version #2737

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Oct 7, 2024

Changes:

This PR adds a space between the "Environments" and "Version" labels in the ImageEnvironmentSelectFormItems component. The change ensures proper spacing in the UI, improving readability.

image.png

Checklist:

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

graphite-app bot commented Oct 7, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @agatha197 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the size:XS ~10 LoC label Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 5.35% 348/6506
🔴 Branches 4.84% 218/4503
🔴 Functions 3.12% 67/2150
🔴 Lines 5.24% 333/6356

Test suite run success

93 tests passing in 12 suites.

Report generated by 🧪jest coverage report action from d0936ef

@agatha197 agatha197 added this to the 24.09 milestone Oct 15, 2024
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Oct 15, 2024

Merge activity

**Changes:**

This PR adds a space between the "Environments" and "Version" labels in the ImageEnvironmentSelectFormItems component. The change ensures proper spacing in the UI, improving readability.

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/bde817ea-7281-4abc-aabe-30d8a7faadce.png)

**Checklist:**

- [ ] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@graphite-app graphite-app bot merged commit d0936ef into main Oct 15, 2024
6 checks passed
@graphite-app graphite-app bot deleted the misc/add-a-space branch October 15, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants