feat: recent session history #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
yomybaby
force-pushed
the
feature/recent-sesison-history
branch
from
77a14d8
to
7946fa7
Compare
yomybaby
force-pushed
the
feature/recent-sesison-history
branch
from
7946fa7
to
c00180f
Compare
agatha197
requested changes
Oct 16, 2024
|
Thank you for reviewing. I have accepted your suggestion. |
Merge activity
|
This pull request introduces several changes to the `react` project to enhance the session management features and improve form handling. The most important changes include adding a new `SessionTemplateModal` component, and enhancing the `SessionLauncherPage` with session history functionality. ### New Features and Components: * **`SessionTemplateModal` Component**: Added a new modal component to display recent session history, allowing users to apply previous session settings easily. (`react/src/components/SessionTemplateModal.tsx`) ### Updates to Session Management: * **Session History Handling**: Introduced a new hook `useRecentSessionHistory` to manage recent session history, including functions to push, clear, and remove session history entries. (`react/src/hooks/backendai.tsx`) * **`SessionLauncherPage`**: Enhanced to include session history functionality, allowing users to start sessions with previously used settings and view recent session history. (`react/src/pages/SessionLauncherPage.tsx`) [[1]](diffhunk://#diff-cb5aa3700f469823d540634a1acf2796ffcfa96416d6fa9333bfab0ff658b2c1R229-R239) [[2]](diffhunk://#diff-cb5aa3700f469823d540634a1acf2796ffcfa96416d6fa9333bfab0ff658b2c1L542-R575) [[3]](diffhunk://#diff-cb5aa3700f469823d540634a1acf2796ffcfa96416d6fa9333bfab0ff658b2c1L652-R694) ### Minor Changes: * **Code Cleanup and Imports**: Various files updated to clean up imports and improve code readability. (`react/src/pages/SessionLauncherPage.tsx`, `react/src/hooks/useBAISetting.tsx`, `react/src/hooks/backendai.tsx`) [[1]](diffhunk://#diff-cb5aa3700f469823d540634a1acf2796ffcfa96416d6fa9333bfab0ff658b2c1R34) [[2]](diffhunk://#diff-cb5aa3700f469823d540634a1acf2796ffcfa96416d6fa9333bfab0ff658b2c1L48-R52) [[3]](diffhunk://#diff-cb5aa3700f469823d540634a1acf2796ffcfa96416d6fa9333bfab0ff658b2c1L62-R66) [[4]](diffhunk://#diff-cb5aa3700f469823d540634a1acf2796ffcfa96416d6fa9333bfab0ff658b2c1L72) [[5]](diffhunk://#diff-cb5aa3700f469823d540634a1acf2796ffcfa96416d6fa9333bfab0ff658b2c1L95-R98) These changes collectively enhance the user experience by providing better session management tools and improving the flexibility and functionality of existing components.
yomybaby
force-pushed
the
refactor/use-event-type-definition
branch
from
1d7ea84
to
253d05e
Compare
yomybaby
force-pushed
the
feature/recent-sesison-history
branch
from
7fb119e
to
a7862fd
Compare
ironAiken2
added a commit
to lablup/backend.ai-docs-webui
that referenced
this pull request
Nov 22, 2024
…modal descriptions (#86) ### This PR is about updating `sessions` section for 24.09 **Changes:** - Starting with Backend.AI version 24.09, NEO session launcher is used as the default session launcher. - Added session owner setting feature. - Added session histyro search function. - Added folder explorer and vfoler creation function in session launcher page. **Related PRs:** - lablup/backend.ai-webui#2742 @yomybaby - lablup/backend.ai-webui#2766 @yomybaby - lablup/backend.ai-webui#2765 @yomybaby - lablup/backend.ai-webui#2745 @ironAiken2 - PDF[kr] : [연산 세션 — Backend.AI Web-UI User Guide 24.03 문서.pdf](https://github.com/user-attachments/files/17486329/Backend.AI.Web-UI.User.Guide.24.03.pdf) - PDF[en] : [Compute Sessions — Backend.AI Web-UI User Guide 24.03 documentation.pdf](https://github.com/user-attachments/files/17486331/Compute.Sessions.Backend.AI.Web-UI.User.Guide.24.03.documentation.pdf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the
reactproject to enhance the session management features and improve form handling. The most important changes include adding a newSessionTemplateModalcomponent, and enhancing theSessionLauncherPagewith session history functionality.New Features and Components:
SessionTemplateModalComponent: Added a new modal component to display recent session history, allowing users to apply previous session settings easily. (react/src/components/SessionTemplateModal.tsx)Updates to Session Management:
useRecentSessionHistoryto manage recent session history, including functions to push, clear, and remove session history entries. (react/src/hooks/backendai.tsx)SessionLauncherPage: Enhanced to include session history functionality, allowing users to start sessions with previously used settings and view recent session history. (react/src/pages/SessionLauncherPage.tsx) [1] [2] [3]Minor Changes:
react/src/pages/SessionLauncherPage.tsx,react/src/hooks/useBAISetting.tsx,react/src/hooks/backendai.tsx) [1] [2] [3] [4] [5]These changes collectively enhance the user experience by providing better session management tools and improving the flexibility and functionality of existing components.