feat: search image with full name in Environment page #2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.4% (-0% 🔻) |
348/6442 |
| 🔴 | Branches | 4.86% (-0% 🔻) |
218/4490 |
| 🔴 | Functions | 3.15% | 67/2125 |
| 🔴 | Lines | 5.29% (-0% 🔻) |
333/6293 |
Test suite run success
93 tests passing in 12 suites.
Report generated by 🧪jest coverage report action from 608d821
Merge activity
|
**Changes:** This PR enhances the image filtering functionality in the ImageList component: 1. Adds a `fullName` property to the image data object, populated with the result of `getImageFullName(image)`. 2. Extends the filtering logic to include a `fullNameMatch` check, allowing users to search for images based on their full names. **Rationale:** Including the full name in the search criteria provides users with more flexibility when filtering images, improving the overall user experience and making it easier to find specific images. **Effects:** - Users can now search for images using their full names, in addition to existing criteria. - Developers working on the ImageList component should be aware of the new `fullName` property and its inclusion in the filtering logic. **Checklist:** - [ ] Documentation: Update user guide to reflect new search capabilities - [ ] Test case: Verify that searching by full image name returns expected results
yomybaby
force-pushed
the
feature/search-image-with-full-name
branch
from
9b09251
to
608d821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR enhances the image filtering functionality in the ImageList component:
fullNameproperty to the image data object, populated with the result ofgetImageFullName(image).fullNameMatchcheck, allowing users to search for images based on their full names.Rationale:
Including the full name in the search criteria provides users with more flexibility when filtering images, improving the overall user experience and making it easier to find specific images.
Effects:
fullNameproperty and its inclusion in the filtering logic.Checklist: