refactor: folder creation modal #2745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ironAiken2 and the rest of your teammates on |
ironAiken2
force-pushed
the
refactor/folder-creation-modal
branch
from
5230fa4 to
6d0d5fa
Compare
This was referenced Oct 10, 2024
Draft
ironAiken2
force-pushed
the
refactor/folder-creation-modal
branch
from
6d0d5fa to
f4d429e
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.36% (-0.03% 🔻) |
348/6488 |
| 🔴 | Branches | 4.84% (-0.01% 🔻) |
218/4503 |
| 🔴 | Functions | 3.12% (-0.02% 🔻) |
67/2146 |
| 🔴 | Lines | 5.25% (-0.03% 🔻) |
333/6338 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / FolderCreateModal.tsx |
0% | 0% | 0% | 0% |
Test suite run success
93 tests passing in 12 suites.
Report generated by 🧪jest coverage report action from d58076b
ironAiken2
force-pushed
the
refactor/folder-creation-modal
branch
2 times, most recently
from
80c27d9 to
a8bd14d
Compare
ironAiken2
force-pushed
the
refactor/folder-creation-modal
branch
from
a8bd14d to
79e6b75
Compare
Merge activity
|
<!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> ### This PR introduces a new `FolderCreateModal` component and integrates it into the `VFolderListPage`. |before|after| |---|---| ||| The new modal provides a interface for creating storage folders with react component. **How to test:** 1. Move to `Data & Storage` page 2. Create a vfolder with new modal 3. Ensure that the new modal covers all of the functionality of the �regacy modal. (e.g. validation logic, conditional options such as clonable, project select, etc..) **Key changes:** - Created a new `FolderCreateModal` component with form fields for folder name, host, usage mode, type, permission, and cloneable option. - Integrated the new modal into `VFolderListPage`, replacing the previous folder creation method. - Added form validation and error handling for folder creation. - Implemented responsive design and styling using Ant Design components and custom styles. **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [x] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
lizable
force-pushed
the
refactor/folder-creation-modal
branch
from
79e6b75 to
d58076b
Compare
|](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/lSyr8xXz1wdXALkJKzVx/55ecbe42-f539-416a-8b63-7daf6132d564.png)||){kind=link}
This was referenced Oct 22, 2024
yomybaby
pushed a commit
that referenced
this pull request
Oct 24, 2024
…2767) <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> ### This PR is about �refactoring the test code via the [folder creation modal change](#2745). **Changes:** - Fixed folder creation modal to pass selectable arguments as props. - Minimized exceptions by specifying types for selectable arguments. - Used `.toBeVisible()` function for vfolder test scenarios to improve accuracy. - When logging out of the page, there was a situation where logging out occurred once more after login, so we minimized the logout by using a new page. **How to test:** - Run the `vfolder.test.ts` test using the vscode playwright extension to verify that there are no errors. - Verify that running the same test multiple times produces the same results. **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
ironAiken2
added a commit
to lablup/backend.ai-docs-webui
that referenced
this pull request
Nov 22, 2024
…#90) ### This PR is about updating `mounting folders to a compute session` section for 24.09 **Changes:** - Added folder explorer functionality within session launcher - Added folder create functionality within session launcher. - Updated images for new components. **Related PR:** - lablup/backend.ai-webui#2766 @yomybaby - lablup/backend.ai-webui#2765 @yomybaby - lablup/backend.ai-webui#2745 @ironAiken2 PDF[ko] : [연산 세션에 폴더 마운트 — Backend.AI Web-UI User Guide 24.03 문서.pdf](https://github.com/user-attachments/files/17515723/Backend.AI.Web-UI.User.Guide.24.03.pdf) PDF[en] : [Mounting Folders to a Compute Session — Backend.AI Web-UI User Guide 24.03 documentation.pdf](https://github.com/user-attachments/files/17515726/Mounting.Folders.to.a.Compute.Session.Backend.AI.Web-UI.User.Guide.24.03.documentation.pdf)
ironAiken2
added a commit
to lablup/backend.ai-docs-webui
that referenced
this pull request
Nov 22, 2024
…modal descriptions (#86) ### This PR is about updating `sessions` section for 24.09 **Changes:** - Starting with Backend.AI version 24.09, NEO session launcher is used as the default session launcher. - Added session owner setting feature. - Added session histyro search function. - Added folder explorer and vfoler creation function in session launcher page. **Related PRs:** - lablup/backend.ai-webui#2742 @yomybaby - lablup/backend.ai-webui#2766 @yomybaby - lablup/backend.ai-webui#2765 @yomybaby - lablup/backend.ai-webui#2745 @ironAiken2 - PDF[kr] : [연산 세션 — Backend.AI Web-UI User Guide 24.03 문서.pdf](https://github.com/user-attachments/files/17486329/Backend.AI.Web-UI.User.Guide.24.03.pdf) - PDF[en] : [Compute Sessions — Backend.AI Web-UI User Guide 24.03 documentation.pdf](https://github.com/user-attachments/files/17486331/Compute.Sessions.Backend.AI.Web-UI.User.Guide.24.03.documentation.pdf)
ironAiken2
added a commit
to lablup/backend.ai-docs-webui
that referenced
this pull request
Nov 22, 2024
### This PR is about updating vfolder section for 24.09 **Changes:** - Added a feature description for the new folder creation modal and updated related images. **Related PR:** - lablup/backend.ai-webui#2745 @ironAiken2 - lablup/backend.ai-webui#2529 @ironAiken2 PDF[ko] : [데이터 & 폴더 활용하기 — Backend.AI Web-UI User Guide 24.03 문서.pdf](https://github.com/user-attachments/files/17488475/Backend.AI.Web-UI.User.Guide.24.03.pdf) PDF[en] : [Handling Data & Storage Folders — Backend.AI Web-UI User Guide 24.03 documentation.pdf](https://github.com/user-attachments/files/17488477/Handling.Data.Storage.Folders.Backend.AI.Web-UI.User.Guide.24.03.documentation.pdf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
FolderCreateModalcomponent and integrates it into theVFolderListPage.The new modal provides a interface for creating storage folders with react component.
How to test:
Data & StoragepageKey changes:
FolderCreateModalcomponent with form fields for folder name, host, usage mode, type, permission, and cloneable option.VFolderListPage, replacing the previous folder creation method.Checklist: (if applicable)