feat: refetch endpoint's models #2747
Merged
+37
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.4% (-0% 🔻) |
348/6441 |
| 🔴 | Branches | 4.86% | 218/4487 |
| 🔴 | Functions | 3.15% (-0% 🔻) |
67/2125 |
| 🔴 | Lines | 5.29% (-0% 🔻) |
333/6292 |
Test suite run success
93 tests passing in 12 suites.
Report generated by 🧪jest coverage report action from a3a8ce3
yomybaby
requested review from
ironAiken2 and
agatha197
and removed request for
ironAiken2
Merge activity
|
 **Changes:** This PR enhances the ChatUIModal, EndpointLLMChatCard, and LLMPlaygroundPage components: 1. Added a refresh button to the "Cannot Find Model" alert in ChatUIModal and EndpointLLMChatCard. 2. Implemented the `destroyOnClose` prop for the Modal component in ChatUIModal. After this change, it refetches models when the modal is opened. 3. `useUpdatableState hook` in EndpointLLMChatCard for managing fetch key. 4. Improved layout and styling of LLMPlaygroundPage, particularly for the card skeleton. **Rationale:** These changes improve user experience by providing a way to refresh model data and enhance the overall UI responsiveness and appearance. **Effects:** - Users can now easily refresh model data when it's not found. - The chat modal will reset its state when closed, ensuring a fresh start on reopening. - The playground page layout is more consistent and visually appealing.
ironAiken2
force-pushed
the
feature/refech-endpoint-models
branch
from
e3b216c
to
a3a8ce3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR enhances the ChatUIModal, EndpointLLMChatCard, and LLMPlaygroundPage components:
destroyOnCloseprop for the Modal component in ChatUIModal. After this change, it refetches models when the modal is opened.useUpdatableState hookin EndpointLLMChatCard for managing fetch key.Rationale:
These changes improve user experience by providing a way to refresh model data and enhance the overall UI responsiveness and appearance.
Effects: