feat: user resource policy allocation in user setting modal #2749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ironAiken2 and the rest of your teammates on |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.35% (-0% 🔻) |
348/6506 |
| 🔴 | Branches | 4.84% | 218/4503 |
| 🔴 | Functions | 3.12% (-0% 🔻) |
67/2150 |
| 🔴 | Lines | 5.24% (-0% 🔻) |
333/6356 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / UserResourcePolicySelector.tsx |
0% | 100% | 0% | 0% |
Test suite run success
93 tests passing in 12 suites.
Report generated by 🧪jest coverage report action from f060300
6 tasks
yomybaby
changed the title
agatha197
approved these changes
Oct 15, 2024
Merge activity
|
<!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> This PR resolves #2727 issue. **Changes:** - The user creation modal is written as a Lit Element, so I applied it to the edit modal first. - When migrating the user creation modal to react component, I �thought that we need a user resource policy selector, so I wrote it as a separate component. - The `user_resource_policy` query doesn't provide filtering options yet, so I didn't add any filtering logic, but used antd's built-in search. **How to test:** - Verify that the existing user's resource policy is properly applied as the default value. - In the user information edit modal, verify that the user's resoure policy is modified correctly. |before|after| |---|---| ||| **Checklist:** (if applicable) - [x] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
ironAiken2
force-pushed
the
feat/user-resource-policy-allocation-in-user-setting-modal
branch
from
b7eac6a to
f060300
Compare
github-actions
bot
added
area:ux
graphite-app
bot
deleted the
feat/user-resource-policy-allocation-in-user-setting-modal
branch
|](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/lSyr8xXz1wdXALkJKzVx/e0c21f2d-a56b-4fd8-ab23-36048c46904d.png)||){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2727 issue.
Changes:
user_resource_policyquery doesn't provide filtering options yet, so I didn't add any filtering logic, but used antd's built-in search.How to test:
Checklist: (if applicable)