Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable LLM Chat button based on endpoint status #2750

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Oct 14, 2024

This PR disables/enables the LLM chat button based on the endpoint status.teams issue.

Changes:

  • Enable the LLM chat button only if the endpoint status is HEALTHY.

How to test:

  • On the endpoint detail page, check whether the LLM chat button is enabled or disabled based on the status.

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

graphite-app bot commented Oct 14, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ironAiken2 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the size:XS ~10 LoC label Oct 14, 2024
Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 5.4% 348/6442
🔴 Branches 4.86% 218/4490
🔴 Functions 3.15% 67/2125
🔴 Lines 5.29% 333/6293

Test suite run success

93 tests passing in 12 suites.

Report generated by 🧪jest coverage report action from c39d6b2

@ironAiken2 ironAiken2 marked this pull request as ready for review October 14, 2024 08:40
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby merged commit df034fc into main Oct 14, 2024
10 checks passed
@yomybaby yomybaby deleted the feat/disable-LLM-chat-button-based-on-status branch October 14, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants