-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace skip
with skipOnClient
to avoid runtime errors
#2751
fix: replace skip
with skipOnClient
to avoid runtime errors
#2751
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on Graphite |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 5.33% | 348/6533 |
🔴 | Branches | 4.82% | 218/4522 |
🔴 | Functions | 3.1% | 67/2163 |
🔴 | Lines | 5.22% | 333/6381 |
Test suite run success
93 tests passing in 12 suites.
Report generated by 🧪jest coverage report action from e43f244
39c2902
to
0956095
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GraphQL server performs argument type checking before evaluating directives. Therefore, even when using @skip
, the argument types must be adhered to. For convenience, let's use @skipOnClient
only when using the uuid argument. In all other cases, consider @skip
first.
Merge activity
|
follows #2743 **Changes:** - Updated `useControllableValue` hook in `EndpointSelect` component to explicitly type it with `string` - Changed `@skip` directive to `@skipOnClient` in GraphQL query for the `endpoint` field **Rationale:** - The explicit typing of `useControllableValue<string>` improves type safety and clarity in the codebase - Switching from `@skip` to `@skipOnClient` directive likely aligns with updated GraphQL schema or client-side optimization strategies **Effects:** - These changes should not directly affect users - Developers will benefit from improved type checking and potentially more efficient GraphQL query execution - Avoid runtime errors when endpoint is empty. **How to test:** 1. Remove all services 2. Enable `enableLLMPlayground` from config.toml 3. Visit LLM Playground page **Checklist for reviewer:** - [ ] Check if runtime error disappears. **Checklist:** - [x] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [x] Specific setting for review (eg., KB link, endpoint or how to setup) - [x] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
0956095
to
e43f244
Compare
follows #2743
Changes:
useControllableValue
hook inEndpointSelect
component to explicitly type it withstring
@skip
directive to@skipOnClient
in GraphQL query for theendpoint
fieldRationale:
useControllableValue<string>
improves type safety and clarity in the codebase@skip
to@skipOnClient
directive likely aligns with updated GraphQL schema or client-side optimization strategiesEffects:
How to test:
enableLLMPlayground
from config.tomlChecklist for reviewer:
Checklist: