feat: add TableColumnSettingModal to ContainerRegistryList
#2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
10 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
agatha197
force-pushed
the
feature/fetch-container-registries-with-nodes
branch
2 times, most recently
from
639bbd7
to
fa69e9c
Compare
agatha197
force-pushed
the
feature/add-TableColumnSettingModal-to-ContainerRegistryList
branch
from
574e64b
to
9464ddf
Compare
agatha197
force-pushed
the
feature/fetch-container-registries-with-nodes
branch
from
fa69e9c
to
18d5597
Compare
agatha197
force-pushed
the
feature/add-TableColumnSettingModal-to-ContainerRegistryList
branch
from
9464ddf
to
711f213
Compare
agatha197
force-pushed
the
feature/fetch-container-registries-with-nodes
branch
from
18d5597
to
84e86de
Compare
agatha197
force-pushed
the
feature/add-TableColumnSettingModal-to-ContainerRegistryList
branch
from
711f213
to
f00dc90
Compare
lizable
force-pushed
the
feature/fetch-container-registries-with-nodes
branch
from
84e86de
to
ccb9a9b
Compare
Base automatically changed from
feature/fetch-container-registries-with-nodes
to
main
October 21, 2024 04:41
lizable
force-pushed
the
feature/add-TableColumnSettingModal-to-ContainerRegistryList
branch
from
f00dc90
to
02b62c3
Compare
Merge activity
|
**Changes:** This PR enhances the ContainerRegistryList component by adding a column visibility feature. Users can now customize which columns are displayed in the registry list table. - Introduced a new TableColumnsSettingModal component for managing column visibility - Added a settings button to toggle the column visibility modal - Implemented local storage state to persist user's column visibility preferences - Refactored the table columns definition for better maintainability - Updated the Table component to use the filtered columns based on user preferences **Rationale:** This change improves the user experience by allowing customization of the registry list view. Users can now focus on the information most relevant to them, reducing clutter and improving efficiency. **Impact:** - Users can now customize their view of the container registry list - Developers can more easily manage and extend the columns in the future **Checklist:** - [ ] Documentation: Update user guide to explain the new column visibility feature - [ ] Minimum requirements to check during review: - Verify that the column visibility modal opens and closes correctly - Ensure that column preferences are saved and persisted across page reloads - Check that the table updates correctly when column visibility is changed
lizable
force-pushed
the
feature/add-TableColumnSettingModal-to-ContainerRegistryList
branch
from
02b62c3
to
805df28
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.15% (-0.01% 🔻) |
348/6760 |
| 🔴 | Branches | 4.69% (-0% 🔻) |
218/4647 |
| 🔴 | Functions | 3.01% (-0.01% 🔻) |
67/2226 |
| 🔴 | Lines | 5.04% (-0.01% 🔻) |
333/6605 |
Test suite run success
93 tests passing in 12 suites.
Report generated by 🧪jest coverage report action from 805df28
graphite-app
bot
deleted the
feature/add-TableColumnSettingModal-to-ContainerRegistryList
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR enhances the ContainerRegistryList component by adding a column visibility feature. Users can now customize which columns are displayed in the registry list table.
Rationale:
This change improves the user experience by allowing customization of the registry list view. Users can now focus on the information most relevant to them, reducing clutter and improving efficiency.
Impact:
Checklist: