Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove legacy user creation modal #2755

Draft
wants to merge 1 commit into
base: feat/user-list-page
Choose a base branch
from

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Oct 16, 2024

Changes:

This PR removes the functionality for adding new users directly from the credential view. Specifically:

  • Removed the newUserDialog query and related dialog HTML
  • Deleted the _launchUserAddDialog and _addUser methods
  • Removed password validation methods: _validatePassword, _validatePassword1, _validatePassword2
  • Deleted the _togglePasswordVisibility method

Rationale:

The user creation functionality has likely been moved to a separate component or is being handled differently in the application. This change simplifies the credential view by focusing it on credential management rather than user management.

Impact:

  • Administrators will no longer be able to add new users directly from the credential view
  • The user interface for the credential view will be cleaner, without the "Add User" dialog
  • Any code relying on the removed methods or dialog will need to be updated

Checklist:

  • Update documentation to reflect the removal of user creation from the credential view
  • Ensure that user creation functionality is available elsewhere in the application
  • Test to confirm that credential management features still work as expected
  • Verify that removing these elements doesn't break any existing functionality

Copy link

graphite-app bot commented Oct 16, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

ironAiken2 commented Oct 16, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ironAiken2 and the rest of your teammates on Graphite Graphite

Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about moving this PR to the parent of #2757, and removing the credential view file?

Copy link
Contributor Author

I've organized the stack so that PR #2754 is merged and used first, but I don't think deleting files is relevant to the actual use of the feature, so I'll stack it above #2757 as you said!

@ironAiken2 ironAiken2 marked this pull request as draft October 18, 2024 04:46
@ironAiken2 ironAiken2 changed the base branch from feat/react-create-user-modal to feat/user-list-page October 18, 2024 04:48
@ironAiken2 ironAiken2 force-pushed the feat/remove-legacy-user-create-modal branch from ba3f04c to c98cc2a Compare October 18, 2024 04:48
@ironAiken2 ironAiken2 force-pushed the feat/remove-legacy-user-create-modal branch from c98cc2a to b23ed6a Compare October 18, 2024 05:06
@ironAiken2 ironAiken2 force-pushed the feat/remove-legacy-user-create-modal branch from b23ed6a to be33acc Compare October 18, 2024 05:09
@yomybaby yomybaby force-pushed the feat/user-list-page branch 2 times, most recently from 1f06be9 to 42880b8 Compare November 6, 2024 08:18
@yomybaby yomybaby force-pushed the feat/remove-legacy-user-create-modal branch from be33acc to c13fd6b Compare November 6, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants