refactor: move useRecentSessionHistory to a separate file #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.11% (+1.07% 🔼) |
348/6809 |
| 🔴 | Branches | 4.66% (+0.66% 🔼) |
218/4682 |
| 🔴 | Functions | 2.98% (+0.45% 🔼) |
67/2246 |
| 🔴 | Lines | 5.01% (+1.08% 🔼) |
333/6653 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / useRecentSessionHistory.tsx |
0% | 0% | 0% | 0% |
Test suite run success
93 tests passing in 12 suites.
Report generated by 🧪jest coverage report action from 39b99a9
yomybaby
force-pushed
the
refactor/use-recent-session-history-to-file
branch
from
096614c
to
39b99a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR refactors the
useRecentSessionHistoryhook by moving it fromhooks/backendai.tsxto its own filehooks/useRecentSessionHistory.tsx. The functionality remains the same, but it's now in a separate, dedicated file for better organization and maintainability.Additionally, this PR resolves the Jest test failure related to importing a file.
Updates:
SessionTemplateModal.tsx: Updated the import path foruseRecentSessionHistory.hooks/backendai.tsx: Removed theuseRecentSessionHistoryhook and its related imports.hooks/useRecentSessionHistory.tsx: Created this new file to house theuseRecentSessionHistoryhook.SessionLauncherPage.tsx: Updated the import path foruseRecentSessionHistory.Rationale:
This refactoring improves code organization by separating concerns and reducing the size of the
backendai.tsxfile. It makes the codebase more modular and easier to maintain.