Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide divider in LLMChatCard #2771

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Oct 23, 2024

This PR is for the conditional divider �render that is missing from the #2762 PR.

before after
image.png image.png
  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

graphite-app bot commented Oct 23, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ironAiken2 and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Oct 23, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 5.09% 348/6837
🔴 Branches
4.64% (-0% 🔻)
218/4698
🔴 Functions 2.97% 67/2256
🔴 Lines 4.99% 333/6678

Test suite run success

93 tests passing in 12 suites.

Report generated by 🧪jest coverage report action from 58c5aac

@ironAiken2 ironAiken2 marked this pull request as ready for review October 23, 2024 07:54
@yomybaby yomybaby force-pushed the fix/hide-divider-in-chat-card branch from 28b47a9 to 557beb9 Compare October 28, 2024 02:17
@github-actions github-actions bot added size:XS ~10 LoC and removed size:S 10~30 LoC labels Oct 28, 2024
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Oct 28, 2024

Merge activity

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

This PR is for the conditional divider �render that is missing from the #2762 PR.

|before|after|
|---|---|
|![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/lSyr8xXz1wdXALkJKzVx/e43dc73e-8a82-4809-88cc-ed40fa5189d5.png)|![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/lSyr8xXz1wdXALkJKzVx/cc530c3f-fd0b-4637-a569-5195b3d3645a.png)|

- [ ] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@yomybaby yomybaby force-pushed the fix/hide-divider-in-chat-card branch from 557beb9 to 58c5aac Compare October 28, 2024 02:21
@graphite-app graphite-app bot merged commit 58c5aac into main Oct 28, 2024
6 checks passed
@graphite-app graphite-app bot deleted the fix/hide-divider-in-chat-card branch October 28, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants