feat: Session detail panel basic layout #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
yomybaby
force-pushed
the
feature/session-detail-panel
branch
2 times, most recently
from
186305d
to
c2393b1
Compare
yomybaby
changed the title
yomybaby
force-pushed
the
feature/session-detail-panel
branch
2 times, most recently
from
d90855a
to
bc869ef
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.95% (-0.1% 🔻) |
349/7050 |
| 🔴 | Branches | 4.5% (-0.14% 🔻) |
218/4845 |
| 🔴 | Functions | 2.9% (-0.07% 🔻) |
67/2312 |
| 🔴 | Lines | 4.85% (-0.1% 🔻) |
334/6888 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / ComputeSessionList.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / SessionDetailContent.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / EditableSessionName.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / SessionActionButtons.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / TerminateSessionModal.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / SessionResourceNumbers.tsx |
0% | 100% | 0% | 0% |
| 🔴 | ... / SessionReservation.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / SessionTypeTag.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / SessionStatusTag.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / SessionDetailDrawer.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / useBackendAIAppLauncher.tsx |
0% | 100% | 0% | 0% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | helper/index.tsx | 52.32% (-0.03% 🔻) |
46.48% | 40.54% (-1.13% 🔻) |
53.85% (-0.06% 🔻) |
| 🔴 | ... / ResourceNumber.tsx |
20% (-1.43% 🔻) |
0% | 0% | 20% (-1.43% 🔻) |
Test suite run success
93 tests passing in 12 suites.
Report generated by 🧪jest coverage report action from f584b49
yomybaby
force-pushed
the
feature/session-detail-panel
branch
3 times, most recently
from
2ce73ff
to
c1f5551
Compare
yomybaby
force-pushed
the
feature/session-detail-panel
branch
from
c1f5551
to
051508f
Compare
yomybaby
force-pushed
the
feature/session-detail-panel
branch
4 times, most recently
from
eb0a0a6
to
2acee4d
Compare
yomybaby
force-pushed
the
feature/session-detail-panel
branch
2 times, most recently
from
655e66a
to
b884206
Compare
ironAiken2
reviewed
Nov 4, 2024
react/src/components/ComputeSessionNodeItems/EditableSessionName.tsx
Outdated
Show resolved
Hide resolved
ironAiken2
reviewed
Nov 4, 2024
ironAiken2
requested changes
Nov 4, 2024
ironAiken2
reviewed
Nov 4, 2024
ironAiken2
reviewed
Nov 4, 2024
ironAiken2
reviewed
Nov 4, 2024
react/src/components/ComputeSessionNodeItems/TerminateSessionModal.tsx
Outdated
Show resolved
Hide resolved
yomybaby
force-pushed
the
feature/session-detail-panel
branch
from
b884206
to
d9f0dbf
Compare
I removed the |
agatha197
requested changes
Nov 4, 2024
yomybaby
force-pushed
the
feature/session-detail-panel
branch
from
d9f0dbf
to
d0aab17
Compare
yomybaby
force-pushed
the
feature/session-detail-panel
branch
from
d0aab17
to
cb73537
Compare
agatha197
requested changes
Nov 4, 2024
agatha197
approved these changes
Nov 5, 2024
yomybaby
force-pushed
the
feature/session-detail-panel
branch
from
cb73537
to
a1cdeb1
Compare
Merge activity
|
Resolve #2784 This PR introduces the Session detail panel. This is the basic version that displays basic information along with 2 action buttons (Open terminal, Terminate Session). You can check the remaining features in #2783.  ### How to test - You can view the Session detail panel by clicking on the session ID in the model service detail page's Routes Info card. - You can open the Session detail panel using deep link (e.g. http://127.0.0.1:9081/job?sessionDetail=d70365e2-8fba-4c9b-bc51-4a9f906866d9)
yomybaby
force-pushed
the
feature/session-detail-panel
branch
from
a1cdeb1
to
f584b49
Compare
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #2784
This PR introduces the Session detail panel. This is the basic version that displays basic information along with 2 action buttons (Open terminal, Terminate Session).
You can check the remaining features in #2783.
How to test