refactor: improve error handling of CustomizedImageList
#2792
+21
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.82% | 349/7244 |
| 🔴 | Branches | 4.41% | 220/4991 |
| 🔴 | Functions | 2.8% | 67/2389 |
| 🔴 | Lines | 4.71% | 334/7085 |
Test suite run success
96 tests passing in 12 suites.
Report generated by 🧪jest coverage report action from 4c04c85
ironAiken2
reviewed
Oct 31, 2024
|
it was possible before lablup/backend.ai#3004 is merged 😅 |
agatha197
force-pushed
the
refactor/improve-error-handling
branch
from
bcec629 to
def93d2
Compare
agatha197
changed the title
MyEnvironment
agatha197
changed the title
CustomizedImageList
Merge activity
|
**Changes:** Improves error handling when deleting customized images by: - Adding specific error checks for `forget_image_by_id` and `untag_image_from_registry` operations - Displaying individual error messages from the error array with 2.5s duration - Only showing success message and refreshing the environment when all operations complete successfully **Checklist:** - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after **Test Cases:** 1. Delete an image with `forget_image_by_id` failure 2. Delete an image with `untag_image_from_registry` failure 3. Delete an image with multiple GraphQL errors 4. Delete an image successfully
yomybaby
force-pushed
the
refactor/improve-error-handling
branch
from
def93d2 to
4c04c85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Improves error handling when deleting customized images by:
forget_image_by_idanduntag_image_from_registryoperationsChecklist:
Test Cases:
forget_image_by_idfailureuntag_image_from_registryfailure