refactor: session launcher image parsing #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
area:ux
This was referenced Oct 31, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
agatha197
force-pushed
the
refactor/session-launcher-image-parsing
branch
from
9473406
to
22fe5c5
Compare
agatha197
force-pushed
the
refactor/new-image-parsing-on-CustomizedImageList
branch
from
d1f8e39
to
694c97a
Compare
agatha197
force-pushed
the
refactor/session-launcher-image-parsing
branch
from
22fe5c5
to
dfef701
Compare
agatha197
force-pushed
the
refactor/new-image-parsing-on-CustomizedImageList
branch
from
694c97a
to
6547cf8
Compare
agatha197
force-pushed
the
refactor/session-launcher-image-parsing
branch
from
dfef701
to
7e5e0e6
Compare
agatha197
force-pushed
the
refactor/new-image-parsing-on-CustomizedImageList
branch
from
6547cf8
to
1344cda
Compare
agatha197
force-pushed
the
refactor/session-launcher-image-parsing
branch
from
7e5e0e6
to
4ff0f26
Compare
agatha197
force-pushed
the
refactor/new-image-parsing-on-CustomizedImageList
branch
from
1344cda
to
eb53937
Compare
agatha197
force-pushed
the
refactor/session-launcher-image-parsing
branch
from
4ff0f26
to
720c2c0
Compare
agatha197
commented
Nov 1, 2024
agatha197
force-pushed
the
refactor/new-image-parsing-on-CustomizedImageList
branch
from
eb53937
to
21bac91
Compare
agatha197
force-pushed
the
refactor/improve-image-filter-of-ImageList
branch
from
781b59f
to
c275f4c
Compare
agatha197
force-pushed
the
refactor/session-launcher-image-parsing
branch
from
bc5e16b
to
898f495
Compare
agatha197
force-pushed
the
refactor/improve-image-filter-of-ImageList
branch
from
c275f4c
to
0d82fac
Compare
agatha197
force-pushed
the
refactor/session-launcher-image-parsing
branch
from
898f495
to
c5f858e
Compare
agatha197
force-pushed
the
refactor/improve-image-filter-of-ImageList
branch
from
0d82fac
to
92743f8
Compare
agatha197
force-pushed
the
refactor/session-launcher-image-parsing
branch
from
c5f858e
to
408f1a0
Compare
agatha197
force-pushed
the
refactor/improve-image-filter-of-ImageList
branch
from
92743f8
to
48670ca
Compare
agatha197
force-pushed
the
refactor/session-launcher-image-parsing
branch
2 times, most recently
from
9a80d06
to
6a2ff3e
Compare
agatha197
force-pushed
the
refactor/improve-image-filter-of-ImageList
branch
from
48670ca
to
40a5692
Compare
agatha197
force-pushed
the
refactor/session-launcher-image-parsing
branch
from
6a2ff3e
to
edc6685
Compare
2 tasks
agatha197
force-pushed
the
refactor/improve-image-filter-of-ImageList
branch
from
40a5692
to
d72575d
Compare
agatha197
force-pushed
the
refactor/session-launcher-image-parsing
branch
from
edc6685
to
e6bf896
Compare
Merge activity
|
agatha197
force-pushed
the
refactor/improve-image-filter-of-ImageList
branch
from
d72575d
to
7eaaad2
Compare
agatha197
force-pushed
the
refactor/session-launcher-image-parsing
branch
from
e6bf896
to
634718c
Compare
**Changes:** This PR enhances the image selection UI to support extended image information in the session launcher, providing more detailed and structured image metadata display. Key updates: - Adds support for displaying base image name, version, architecture and tags in a more organized format - Introduces tag aliasing functionality to show more user-friendly tag names - Updates the image selection interface to show customized image tags with distinct styling - Adds translations for "Tags" across all supported languages **Minimum required manager version:** 24.09.1 **Review Requirements:** 1. Verify extended image info display works when backend supports 'extended-image-info' feature 2. Check tag aliasing correctly translates technical tags to user-friendly names 3. Confirm customized image tags are properly highlighted with cyan color 4. Validate all translations for "Tags" appear correctly across languages **Test Cases:** 1. Select an image with extended info: - Should show base image name, version, architecture and tags - Tags should display with proper aliasing 2. Select a customized image: - Should show customized tag with cyan highlighting - Should display proper customized image name from labels 3. Test with extended-image-info feature disabled: - Should fallback to legacy image info display format 4. Test the image of `Environments & Resource allocation` page and `Confirm and Launch` page has the same value. **Screenshots:** 
agatha197
force-pushed
the
refactor/improve-image-filter-of-ImageList
branch
from
7eaaad2
to
eac1fb5
Compare
agatha197
force-pushed
the
refactor/session-launcher-image-parsing
branch
from
634718c
to
90e46f6
Compare
Base automatically changed from
refactor/improve-image-filter-of-ImageList
to
main
November 5, 2024 10:46
3 tasks
yomybaby
pushed a commit
that referenced
this pull request
Nov 12, 2024
) **Changes:** Refactored image handling similar to #2800 for versions before 24.12. Before 24.12, most data parsing is handled on the frontend. - Unified the display format of image information across components - Added base version and image tags display - Replaced custom tag display with standardized ImageTags component - Removed conditional rendering based on extended image info support **Rationale:** The changes provide a more uniform and informative way to display image metadata, making it easier for users to understand the characteristics of selected container images. **What to check:** Data parsing is the same as 24.12. **Effects:** Users will see: - Consistent image information display format - Clearer representation of image base versions - Standardized tag display across the interface - More detailed image metadata including architecture and labels **Screenshots:**  **Checklist:** - [ ] Documentation - [ ] Test cases to verify image information display - [ ] Verify tag display functionality across different image types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR enhances the image selection UI to support extended image information in the session launcher, providing more detailed and structured image metadata display.
Key updates:
Minimum required manager version: 24.09.1
Review Requirements:
Test Cases:
Environments & Resource allocationpage andConfirm and Launchpage has the same value.Screenshots: