refactor: add more tagReplace patterns #2816
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
agatha197
added
the
type:refactor
Graphite App
| @@ -891,7 +891,16 @@ | |||
| "tagReplace": { | |||
| "^(tf)([0-9.]*)$": "TensorFlow $2", | |||
| "^(pytorch)([0-9.]*)$": "PyTorch $2", | |||
| "^py(\\d)(\\d+)$": "Python $1.$2", | |||
There was a problem hiding this comment.
Handling versions without dots using regular expressions isn't ideal since major versions can be two digits. It's better to use explicit tag aliases for such cases.
There was a problem hiding this comment.
But we have to update whenever python is updated. py312,py313,py314....
Merge activity
|
Adds additional tag pattern replacements for image metadata This PR extends the tag replacement patterns in `image_metadata.json` to support more standardized formatting of: - Python versions (py35 → Python 3.5) - ROCm GPU versions (rocm5 → GPU:ROCm5) - Ubuntu versions (ubuntu20.04 → Ubuntu 20.04) - Anaconda versions (anaconda3.7 → Anaconda 3.7) - Julia versions (ji1.6 → Julia 1.6) - TPU versions (tpuv3 → TPU:TPUv3) - Alpine Linux versions (alpine3 → Alpine Linux 3) **Checklist:** - [ ] Documentation - [ ] Test case(s) to demonstrate the difference of before/after Example transformations: ``` py37 → Python 3.7 rocm5 → GPU:ROCm5 ubuntu20.04 → Ubuntu 20.04 ji1.6 → Julia 1.6 tpuv3 → TPU:TPUv3 alpine3 → Alpine Linux 3 ```
yomybaby
force-pushed
the
refactor/add-more-tagReplace-patterns
branch
from
89f31aa
to
06d5f40
Compare
Adds additional tag pattern replacements for image metadata
This PR extends the tag replacement patterns in
image_metadata.jsonto support more standardized formatting of:Checklist:
Example transformations: