feat: display kernel node id and idx in Kernel select component #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.03% | 367/7296 |
| 🔴 | Branches | 4.39% | 221/5035 |
| 🔴 | Functions | 2.95% | 71/2409 |
| 🔴 | Lines | 4.93% | 352/7135 |
Test suite run success
100 tests passing in 13 suites.
Report generated by 🧪jest coverage report action from 90496bc
rapsealk
reviewed
Nov 11, 2024
rapsealk
requested changes
Nov 11, 2024
yomybaby
changed the title
yomybaby
force-pushed
the
feature/display-kernel-id-in-select
branch
from
a410bf9 to
2a0de33
Compare
|
For admin and superadmin: For others: Also, I changed the sorting function for the Kernel role select's options. |
Merge activity
|
Resolves #2833  **Changes:** Enhances the container log modal dropdown by adding node IDs alongside cluster roles. The first 5 characters of each node's row_id are now displayed in a monospace font next to the cluster role, making it easier to identify specific nodes. **Visual Impact:** The dropdown now shows entries in the format: `cluster_role (12345)` where the ID portion is styled with a monospace font and secondary color.
yomybaby
force-pushed
the
feature/display-kernel-id-in-select
branch
from
2a0de33 to
90496bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2833
Changes:
Enhances the container log modal dropdown by adding node IDs alongside cluster roles. The first 5 characters of each node's row_id are now displayed in a monospace font next to the cluster role, making it easier to identify specific nodes.
Visual Impact:
The dropdown now shows entries in the format:
cluster_role (12345)where the ID portion is styled with a monospace font and secondary color.