Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: NVIDIA icon and component #2863

Merged
merged 1 commit into from
Nov 20, 2024
Merged

chore: NVIDIA icon and component #2863

merged 1 commit into from
Nov 20, 2024

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Nov 20, 2024

Resolves #2862

image.png

image.png

Changes:
Replaced NVIDIA PNG icon with SVG version and added a new React NVIDIA icon component with the following improvements:

  • Converted static PNG to scalable SVG format for better visual quality
  • Added a new NvidiaIcon React component with customizable size and styling
  • Updated icon references in app templates and metadata to use SVG format
  • Set default NVIDIA brand color (#76B900) for consistent branding

Rationale:
SVG format provides better scaling and visual quality across different display resolutions while reducing file size. The new React component enables consistent NVIDIA branding across the application with customizable styling options.

Checklist:

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Review Points:

  • Verify NVIDIA icon displays correctly in all referenced locations
  • Confirm SVG scaling works properly at different sizes
  • Check brand color (#76B900) renders correctly

Copy link

graphite-app bot commented Nov 20, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the area:ux UI / UX issue. label Nov 20, 2024
@github-actions github-actions bot added the size:M 30~100 LoC label Nov 20, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
5.38% (-0% 🔻)
395/7344
🔴 Branches 4.67% 237/5077
🔴 Functions
3.22% (-0% 🔻)
78/2421
🔴 Lines
5.29% (-0% 🔻)
380/7184
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / Nvidia.tsx
0% 100% 0% 0%

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 817af23

@yomybaby yomybaby marked this pull request as ready for review November 20, 2024 02:56
@yomybaby yomybaby merged commit 19f959b into main Nov 20, 2024
10 checks passed
@yomybaby yomybaby deleted the chore/update-nvidia-icon branch November 20, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ux UI / UX issue. size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Nvidia logo
1 participant