feat: Set the initial value of the chat modal to the recently created token #2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.37% (+0.08% 🔼) |
395/7352 |
| 🔴 | Branches | 4.67% (+0.08% 🔼) |
237/5080 |
| 🔴 | Functions | 3.22% (+0.06% 🔼) |
78/2422 |
| 🔴 | Lines | 5.28% (+0.08% 🔼) |
380/7192 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from cf3c4b3
yomybaby
changed the title
yomybaby
changed the title
yomybaby
changed the title
agatha197
force-pushed
the
refactor/set-the-most-recently-created-token-as-the-placeholder
branch
from
bd8f2bc to
cf3c4b3
Compare
Merge activity
|
… token (#2864) resolves #2865 **Changes:** Adds automatic token population in the chat UI modal by passing the most recently created endpoint token to the chat interface. **Details:** - Extends `ChatUIModal` to accept endpoint token fragment data - Adds logic to find the newest token from the endpoint token list - Automatically populates the token field in the chat interface with the most recent token - Enhances user experience by removing manual token entry requirement **How to test:** 1. Click the LLM Chat Test from the serving page. 2. If it is not a public vllm model, you can get the custom modal. 3. If there are tokens, the most recently created and valid token will be set as the placeholder. 4. If there is no valid token, the placeholder is empty. **Checklist:** - [x] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [x] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after **Review Requirements:** 1. Verify that the newest token is correctly identified from the endpoint token list 2. Confirm the token field is pre-populated in the chat interface 3. Test that the chat functionality works with the auto-populated token
yomybaby
force-pushed
the
refactor/set-the-most-recently-created-token-as-the-placeholder
branch
from
cf3c4b3 to
cec0a33
Compare
graphite-app
bot
deleted the
refactor/set-the-most-recently-created-token-as-the-placeholder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2865
Changes:
Adds automatic token population in the chat UI modal by passing the most recently created endpoint token to the chat interface.
Details:
ChatUIModalto accept endpoint token fragment dataHow to test:
Checklist:
Review Requirements: