Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add the missing session type argument to the SFTP session creation API #2869

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

jopemachine
Copy link
Member

This PR resolves an issue where the SFTP session is created as an interactive session rather than an upload session due to the missing session type argument.

Checklist: (if applicable)

  • Mention to the original issue
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Test case(s) to demonstrate the difference of before/after

@jopemachine jopemachine added the type:fix Fix features that are not working label Nov 21, 2024
@jopemachine jopemachine added this to the 24.03 milestone Nov 21, 2024
Copy link

graphite-app bot commented Nov 21, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@jopemachine jopemachine self-assigned this Nov 21, 2024
@github-actions github-actions bot added the size:XS ~10 LoC label Nov 21, 2024
@jopemachine jopemachine changed the title fix: Add the missing session type argument to the SFTP session creation API fix: Add the missing session type argument to the SFTP session creation API Nov 21, 2024
@jopemachine jopemachine marked this pull request as ready for review November 21, 2024 08:23
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby self-requested a review November 21, 2024 09:16
@yomybaby yomybaby merged commit c28998e into main Nov 21, 2024
8 checks passed
@yomybaby yomybaby deleted the fix/sftp-session-created-as-interactive branch November 21, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS ~10 LoC type:fix Fix features that are not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants