Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Smooth transition for Container Registry enable switch #2881

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Nov 26, 2024

Resolve #2880

Changes:
Updates the container registry list fetch behavior to use different Apollo fetch policies based on whether it's the initial fetch or a subsequent reload:

  • Initial fetch uses store-and-network to show cached data while fetching fresh data
  • Subsequent fetches use network-only to ensure fresh data

Rationale:
This change optimizes the user experience by showing cached data immediately on first load while still ensuring up-to-date data on manual refreshes.

Copy link

graphite-app bot commented Nov 26, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yomybaby yomybaby marked this pull request as ready for review November 26, 2024 03:25
@yomybaby yomybaby marked this pull request as draft November 26, 2024 03:25
Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
5.28% (+0.01% 🔼)
395/7480
🔴 Branches
4.58% (+0.01% 🔼)
237/5175
🔴 Functions
3.16% (+0% 🔼)
78/2468
🔴 Lines
5.2% (+0.01% 🔼)
380/7313

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 17b46f7

@yomybaby yomybaby marked this pull request as ready for review November 26, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Transition Handling for Container Registry Enable Switch in WebUI
1 participant