feat: delete legacy agent summary files #2883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2 tasks
yomybaby
requested changes
Nov 27, 2024
There was a problem hiding this comment.
Could you add a undfined type to _customTheme in customThemeConfig.ts?
let _customTheme: {
light: ThemeConfig;
dark: ThemeConfig;
logo: LogoConfig;
sider?: SiderConfig;
branding?: BrandingConfig;
} | undefined;
agatha197
force-pushed
the
refactor/new-agent-summary-page
branch
from
65961ef to
cf4788f
Compare
agatha197
force-pushed
the
feature/delete-legacy-agent-summary-files
branch
from
f191f90 to
e0653cd
Compare
|
Done! |
2 tasks
Merge activity
|
**Changes:** - Removed deprecated agent summary view and list components - Added optional chaining operator for `themeConfig?.sider?.theme` to prevent potential undefined errors in WebUISider component - Removed unused `agent-summary` route from backend-ai-app loadPage function **Rationale:** The agent summary components were legacy code that is no longer used in the current architecture. Removing them reduces code complexity and maintenance burden. The optional chaining addition helps prevent runtime errors when theme configuration is not fully defined. **Checklist:** - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
force-pushed
the
refactor/new-agent-summary-page
branch
from
cf4788f to
ce77235
Compare
yomybaby
force-pushed
the
feature/delete-legacy-agent-summary-files
branch
from
e0653cd to
343eeed
Compare
graphite-app
bot
deleted the
feature/delete-legacy-agent-summary-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
themeConfig?.sider?.themeto prevent potential undefined errors in WebUISider componentagent-summaryroute from backend-ai-app loadPage functionRationale:
The agent summary components were legacy code that is no longer used in the current architecture. Removing them reduces code complexity and maintenance burden. The optional chaining addition helps prevent runtime errors when theme configuration is not fully defined.
Checklist: