chore: define extra globalThis properties

react/src/components/BAIErrorBoundary.tsx

@@ -27,9 +27,7 @@ const BAIErrorBoundary: React.FC<BAIErrorBoundaryProps> = ({ ...props }) => {
                   type="primary"
                   key="console"
                   onClick={() => {
-                    // @ts-ignore
                     if (globalThis.isElectron) {
-                      // @ts-ignore
                       globalThis.location.href = globalThis.electronInitialHref;
                     } else {
                       globalThis.location.reload();
@@ -89,9 +87,7 @@ export const ErrorView = () => {
             type="primary"
             key="console"
             onClick={() => {
-              // @ts-ignore
               if (globalThis.isElectron) {
-                // @ts-ignore
                 globalThis.location.href = globalThis.electronInitialHref;
               } else {
                 globalThis.location.reload();

react/src/components/ComputeSessionNodeItems/TerminateSessionModal.tsx

@@ -87,13 +87,10 @@ const getWSProxyVersion = async (
 ) => {
   // TODO: remove globalThis.appLauncher(backend-ai-app-launcher) dependency after migration to React
   if (baiClient.debug === true) {
-    // @ts-ignore
     if (globalThis.appLauncher?.forceUseV1Proxy?.checked) return 'v1';
-    // @ts-ignore
     else if (globalThis.appLauncher?.forceUseV2Proxy?.checked) return 'v2';
   }
 
-  // @ts-ignore
   if (globalThis.isElectron) {
     return 'v1';
   }

react/src/components/LoginSessionExtendButton.tsx

@@ -43,9 +43,7 @@ const LoginSessionExtendButton: React.FC<
           const duration = dayjs.duration(Math.max(0, diff), 'seconds');
           const days = Math.floor(duration.asDays());
           if (duration.asSeconds() <= 0) {
-            // @ts-ignore
             if (globalThis.isElectron) {
-              // @ts-ignore
               globalThis.location.href = globalThis.electronInitialHref;
             } else {
               globalThis.location.reload();

react/src/hooks/useThemeMode.tsx

@@ -52,7 +52,6 @@ export const ThemeModeProvider: React.FC<PropsWithChildren> = ({
       } else {
         document.body.classList.remove('dark-theme');
       }
-      // @ts-ignore
       globalThis.isDarkMode = value;
 
       document.dispatchEvent(

react/src/pages/SessionLauncherPage.tsx

@@ -663,8 +663,7 @@ const SessionLauncherPage = () => {
 
                 // only launch app when it has valid service ports
                 if (service_info.length > 0) {
-                  // @ts-ignore
-                  globalThis.appLauncher.showLauncher(appOptions);
+                  globalThis.appLauncher.showLauncher?.(appOptions);
                 }
               }
             },

react/src/pages/UserSettingsPage.tsx

@@ -4,6 +4,7 @@ import SSHKeypairManagementModal from '../components/SSHKeypairManagementModal';
 import { SettingItemProps } from '../components/SettingItem';
 import SettingList from '../components/SettingList';
 import ShellScriptEditModal from '../components/ShellScriptEditModal';
+import { filterEmptyItem } from '../helper';
 import {
   useBAISettingGeneralState,
   useBAISettingUserState,
@@ -53,7 +54,7 @@ const UserPreferencesPage = () => {
   const settingGroup: { title: string; settingItems: SettingItemProps[] }[] = [
     {
       title: t('usersettings.Preferences'),
-      settingItems: [
+      settingItems: filterEmptyItem([
         {
           type: 'checkbox',
           title: t('usersettings.DesktopNotification'),
@@ -126,22 +127,19 @@ const UserPreferencesPage = () => {
             console.log(globalThis.backendaioptions.get('selected_language'));
           },
         },
-        ...[
+        globalThis.isElectron && {
+          type: 'checkbox',
+          title: t('usersettings.KeepLoginSessionInformation'),
+          description: (
+            <Trans i18nKey="usersettings.DescKeepLoginSessionInformation" />
+          ),
+          defaultValue: false,
           //@ts-ignore
-          globalThis.isElectron && {
-            type: 'checkbox',
-            title: t('usersettings.KeepLoginSessionInformation'),
-            description: (
-              <Trans i18nKey="usersettings.DescKeepLoginSessionInformation" />
-            ),
-            defaultValue: false,
-            //@ts-ignore
-            value: preserveLogin,
-            onChange: (e: any) => {
-              setPreserveLogin(e.target.checked);
-            },
+          value: preserveLogin,
+          onChange: (e: any) => {
+            setPreserveLogin(e.target.checked);
           },
-        ].filter(Boolean),
+        },
         {
           type: 'checkbox',
           title: t('usersettings.AutomaticUpdateCheck'),
@@ -202,7 +200,7 @@ const UserPreferencesPage = () => {
             setIsClassicSessionLauncher(e.target.checked);
           },
         },
-      ],
+      ]),
     },
     {
       title: t('usersettings.ShellEnvironments'),

react/src/react-app-env.d.ts

@@ -11,9 +11,27 @@ type ArgumentTypes<F extends Function> = F extends (...args: infer A) => any
   ? A
   : never;
 
-//TODO: fix this declaration for globalThis. It's not working.
-declare global {
+declare module globalThis {
   var isDarkMode: boolean;
+  var isElectron: boolean;
+  var electronInitialHref: string;
+  var appLauncher: {
+    showLauncher?: (sessionId: {
+      'session-name'?: string;
+      'session-uuid'?: string;
+      'access-key'?: string;
+      mode?: SessionMode;
+      'app-services'?: Array<string>;
+      runtime?: string;
+      filename?: string;
+    }) => void;
+    forceUseV1Proxy?: {
+      checked: boolean;
+    };
+    forceUseV2Proxy?: {
+      checked: boolean;
+    };
+  };
 }
 
 type DeepPartial<T> = {