Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package name according to matplotlib API changes #399

Merged

Conversation

mgiustina
Copy link
Contributor

@mgiustina mgiustina commented Jan 13, 2017

NavigationToolbar2QTAgg was removed in matplotlib v1.5.0 (“Added no functionality over the base NavigationToolbar2Qt”). Now revert to NavigationToolbar2QT.

see: http://matplotlib.org/api/api_changes.html#remove-navigationtoolbar2qtagg

Fixes #398

NavigationToolbar2QTAgg was removed in matplotlib v1.5.0 (“Added no functionality over the base NavigationToolbar2Qt”). Now revert to NavigationToolbar2QT.
see: http://matplotlib.org/api/api_changes.html#remove-navigationtoolbar2qtagg

Fixes #398
Copy link
Member

@DanielSank DanielSank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@amitsv1 amitsv1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@DanielSank
Copy link
Member

@mgiustina you can merge this.

@jwenner
Copy link
Contributor

jwenner commented Jan 17, 2017

Does this also fix #359 and #374?

@mgiustina
Copy link
Contributor Author

It should fix #359, but not #374.

@mgiustina mgiustina merged commit 86e83f1 into master Jan 17, 2017
@mgiustina mgiustina deleted the u/mgiustina/398-labradplotwidget3-import-navigation_toolbar branch January 17, 2017 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants