fix(main): fix: skip pulling app image (#3649)

Signed-off-by: cuisongliu <[email protected]>
labring · Aug 9, 2023 · 81609b2 · 81609b2
1 parent dc76a9c
commit 81609b2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/pkg/apply/processor/interface.go b/pkg/apply/processor/interface.go
@@ -191,7 +191,7 @@ func MountClusterImages(bdah buildah.Interface, cluster *v2.Cluster, skipApp boo
 				hasRootfsType = true
 			}
 		}
-		if imageType != "" && imageType != string(v2.RootfsImage) && imageType != string(v2.PatchImage) && skipApp {
+		if (imageType == "" || imageType == string(v2.AppImage)) && skipApp {
 			// then it's an application type image
 			continue
 		}

diff --git a/pkg/apply/processor/scale.go b/pkg/apply/processor/scale.go
@@ -162,11 +162,11 @@ func (c *ScaleProcessor) preProcess(cluster *v2.Cluster) error {
 	if err != nil {
 		return err
 	}
-	// cluster status might be overwrite by inappropriate usage, add mounts if loss.
-	if err = MountClusterImages(c.Buildah, cluster, true); err != nil {
-		return err
-	}
 	if c.IsScaleUp {
+		// cluster status might be overwrite by inappropriate usage, add mounts if loss.
+		if err = MountClusterImages(c.Buildah, cluster, true); err != nil {
+			return err
+		}
 		if cluster.GetRootfsImage().KubeVersion() == "" {
 			return fmt.Errorf("rootfs image not found kube version")
 		}